From: Alex Deucher <alexdeucher@gmail.com>
To: sunran001@208suo.com
Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: add missing spaces after ', ' and else should follow close brace '}'
Date: Mon, 24 Jul 2023 17:39:24 -0400 [thread overview]
Message-ID: <CADnq5_M7x2js7C4fAUVsOd6YAfExqjVW5AapiqDxRQo2e4stBA@mail.gmail.com> (raw)
In-Reply-To: <d88773902f7a8536a8be83ead18981b3@208suo.com>
Applied. Thanks!
Alex
On Sun, Jul 23, 2023 at 11:30 PM <sunran001@208suo.com> wrote:
>
> ERROR: else should follow close brace '}'
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
> b/drivers/gpu/drm/radeon/radeon_connectors.c
> index 07193cd0c417..4ceceb972e8d 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -198,8 +198,7 @@ int radeon_get_monitor_bpc(struct drm_connector
> *connector)
> DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using
> %d bpc.\n",
> connector->name, bpc);
> }
> - }
> - else if (bpc > 8) {
> + } else if (bpc > 8) {
> /* max_tmds_clock missing, but hdmi spec mandates it for deep color.
> */
> DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing.
> Using 8 bpc.\n",
> connector->name);
> @@ -1372,7 +1371,7 @@ radeon_dvi_detect(struct drm_connector *connector,
> bool force)
> /* assume digital unless load detected otherwise */
> radeon_connector->use_digital = true;
> lret = encoder_funcs->detect(encoder, connector);
> - DRM_DEBUG_KMS("load_detect %x returned:
> %x\n",encoder->encoder_type,lret);
> + DRM_DEBUG_KMS("load_detect %x returned: %x\n",
> encoder->encoder_type, lret);
> if (lret == connector_status_connected)
> radeon_connector->use_digital = false;
> }
prev parent reply other threads:[~2023-07-24 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230724032920.7892-1-xujianghui@cdjrlc.com>
2023-07-24 3:30 ` [PATCH] drm/radeon: add missing spaces after ',' and else should follow close brace '}' sunran001
2023-07-24 21:39 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_M7x2js7C4fAUVsOd6YAfExqjVW5AapiqDxRQo2e4stBA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunran001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).