* [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()
@ 2025-07-09 19:02 Christophe JAILLET
2025-07-11 21:10 ` Alex Deucher
2025-07-16 19:46 ` Alex Deucher
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-07-09 19:02 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Sunil Khatri
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, amd-gfx,
dri-devel
If kasprintf() fails, some mutex still need to be released to avoid locking
issue, as already done in all other error handling path.
Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
index 513bbc543f40..bce97318965c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
@@ -520,8 +520,10 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args)
}
queue_name = kasprintf(GFP_KERNEL, "queue-%d", qid);
- if (!queue_name)
- return -ENOMEM;
+ if (!queue_name) {
+ r = -ENOMEM;
+ goto unlock;
+ }
/* Queue dentry per client to hold MQD information */
queue->debugfs_queue = debugfs_create_dir(queue_name, filp->debugfs_client);
--
2.50.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()
2025-07-09 19:02 [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create() Christophe JAILLET
@ 2025-07-11 21:10 ` Alex Deucher
2025-07-16 19:46 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2025-07-11 21:10 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Sunil Khatri, linux-kernel, kernel-janitors, amd-gfx, dri-devel
On Wed, Jul 9, 2025 at 3:28 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If kasprintf() fails, some mutex still need to be released to avoid locking
> issue, as already done in all other error handling path.
>
> Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
@Christian Koenig @Sunil Khatri can you pick this up for drm-misc?
Thanks,
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 513bbc543f40..bce97318965c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -520,8 +520,10 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args)
> }
>
> queue_name = kasprintf(GFP_KERNEL, "queue-%d", qid);
> - if (!queue_name)
> - return -ENOMEM;
> + if (!queue_name) {
> + r = -ENOMEM;
> + goto unlock;
> + }
>
> /* Queue dentry per client to hold MQD information */
> queue->debugfs_queue = debugfs_create_dir(queue_name, filp->debugfs_client);
> --
> 2.50.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()
2025-07-09 19:02 [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create() Christophe JAILLET
2025-07-11 21:10 ` Alex Deucher
@ 2025-07-16 19:46 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2025-07-16 19:46 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Sunil Khatri, linux-kernel, kernel-janitors, amd-gfx, dri-devel
On Wed, Jul 9, 2025 at 3:28 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If kasprintf() fails, some mutex still need to be released to avoid locking
> issue, as already done in all other error handling path.
>
> Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
and pushed out to drm-misc-next.
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 513bbc543f40..bce97318965c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -520,8 +520,10 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args)
> }
>
> queue_name = kasprintf(GFP_KERNEL, "queue-%d", qid);
> - if (!queue_name)
> - return -ENOMEM;
> + if (!queue_name) {
> + r = -ENOMEM;
> + goto unlock;
> + }
>
> /* Queue dentry per client to hold MQD information */
> queue->debugfs_queue = debugfs_create_dir(queue_name, filp->debugfs_client);
> --
> 2.50.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-16 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09 19:02 [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create() Christophe JAILLET
2025-07-11 21:10 ` Alex Deucher
2025-07-16 19:46 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).