From: Alex Deucher <alexdeucher@gmail.com>
To: Randy Dunlap <rdunlap@bombadil.infradead.org>
Cc: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
"Chen, Guchun" <guchun.chen@amd.com>,
Dave Airlie <airlied@linux.ie>,
John Clements <John.Clements@amd.com>,
Tao Zhou <tao.zhou1@amd.com>, LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Huang Rui <ray.huang@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Jiansong Chen <Jiansong.Chen@amd.com>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Likun Gao <Likun.Gao@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH V2] drm/amdgpu: Fix a typo
Date: Mon, 22 Mar 2021 09:58:48 -0400 [thread overview]
Message-ID: <CADnq5_Muaa7MLsiUL+pyV16_HuhKJg=jwS8FwCSvgWgGH11LvQ@mail.gmail.com> (raw)
In-Reply-To: <3cc678f2-36d1-1af1-5759-37aea82f41ea@bombadil.infradead.org>
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
<rdunlap@bombadil.infradead.org> wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > Changes from V1:
> > Alex and Randy's suggestions incorporated.
> >
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..bf3857867f51 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > - * saving the content of this bottom VRAM to system memory
> > - * before training, and restoring it after training to avoid
> > - * VRAM corruption.
> > + * Long training will encroach a certain amount on the bottom of VRAM;
> > + * save the content from the bottom VRAM to system memory
> > + * before training, and restore it after training to avoid
> > + * VRAM corruption.
>
> These 3 new lines are indented with spaces instead of tabs. Oops. :(
>
> (I may be too late with this comment -- sorry about that.)
I fixed that up when I applied it.
Thanks,
Alex
>
> > */
> > sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
> >
> > --
> > 2.26.2
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-03-22 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 20:24 [PATCH V2] drm/amdgpu: Fix a typo Bhaskar Chowdhury
2021-03-20 2:27 ` Randy Dunlap
2021-03-22 13:58 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_Muaa7MLsiUL+pyV16_HuhKJg=jwS8FwCSvgWgGH11LvQ@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jiansong.Chen@amd.com \
--cc=John.Clements@amd.com \
--cc=Likun.Gao@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guchun.chen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=rdunlap@bombadil.infradead.org \
--cc=tao.zhou1@amd.com \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).