From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 2/2] drm: Return -ENOTSUPP when called for KMS cap with a non-KMS driver Date: Wed, 30 Nov 2016 12:21:02 -0500 Message-ID: References: <20161130083002.1520-1-michel@daenzer.net> <20161130083002.1520-2-michel@daenzer.net> <20161130090758.kzrvr2c6tt55vnpw@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x243.google.com (mail-yw0-x243.google.com [IPv6:2607:f8b0:4002:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 997F86E377 for ; Wed, 30 Nov 2016 17:21:03 +0000 (UTC) Received: by mail-yw0-x243.google.com with SMTP id r204so15055580ywb.3 for ; Wed, 30 Nov 2016 09:21:03 -0800 (PST) In-Reply-To: <20161130090758.kzrvr2c6tt55vnpw@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: =?UTF-8?Q?Michel_D=C3=A4nzer?= , Maling list - DRI developers , Dmitry Vyukov List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMzAsIDIwMTYgYXQgNDowNyBBTSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZm d2xsLmNoPiB3cm90ZToKPiBPbiBXZWQsIE5vdiAzMCwgMjAxNiBhdCAwNTozMDowMlBNICswOTAw LCBNaWNoZWwgRMOkbnplciB3cm90ZToKPj4gRnJvbTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5k YWVuemVyQGFtZC5jb20+Cj4+Cj4+IFRoaXMgaXMgYW4gYXR0ZW1wdCB0byBtYWtlIHRoZSBwcmV2 aW91cyBmaXggYSBiaXQgbW9yZSByb2J1c3QgZ29pbmcKPj4gZm9yd2FyZC4KPj4KPj4gU2lnbmVk LW9mZi1ieTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVyQGFtZC5jb20+Cj4+IC0tLQo+ PiAgZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jIHwgMjMgKysrKysrKysrKysrKysrKystLS0t LS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9pb2N0bC5jCj4+IGluZGV4IDcxYzM0NzMuLjMyZjQ4NGIgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faW9jdGwuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2lvY3RsLmMKPj4gQEAgLTIyOSw2ICsyMjksMTkgQEAgc3RhdGljIGludCBkcm1fZ2V0Y2Fw KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmls ZV8KPj4gICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+Pgo+PiAgICAgICByZXEtPnZhbHVl ID0gMDsKPj4gKwo+PiArICAgICAvKiBPbmx5IGFsbG93IG5vbi1LTVMgY2FwcyB3aXRoIG5vbi1L TVMgZHJpdmVycyAqLwo+PiArICAgICBzd2l0Y2ggKHJlcS0+Y2FwYWJpbGl0eSkgewo+PiArICAg ICBjYXNlIERSTV9DQVBfRFVNQl9CVUZGRVI6Cj4KPiBEdW1iIGJ1ZmZlcnMgYXJlIG9ubHkgbWVh bnQgdG8gYmUgdXNlZCBmb3Iga21zIGRyaXZlcnMsIHNob3VsZCBiZQo+IGRpc2FsbG93ZWQgdG9v Lgo+Cj4+ICsgICAgIGNhc2UgRFJNX0NBUF9WQkxBTktfSElHSF9DUlRDOgo+Cj4gTWlnaHQgYmUg Z29vZCB0byBoYXZlIGEgY29tbWVudCBoZXJlIHRoYXQgd2UgbmVlZCB0byBhbGxvdyB0aGlzIGZv ciBvbGQKPiB1bXM/Cj4KCkkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0aGlzIGZvciBVTVMuICBJdCB3 YXMgYWRkZWQgZm9yIGV2ZXJncmVlbiBhbmQgd2UKb25seSBzdXBwb3J0ZWQgdGhpcyBmZWF0dXJl IG9uIEtNUy4KCkFsZXgKCj4+ICsgICAgIGNhc2UgRFJNX0NBUF9QUklNRToKPj4gKyAgICAgY2Fz ZSBEUk1fQ0FQX1RJTUVTVEFNUF9NT05PVE9OSUM6Cj4KPiBUaGlzIGlzIHByZXR0eSBuZXcsIEkg ZG9uJ3QgdGhpbmsgYW55IG9mIHRoZSBvbGQgdW1zIGRyaXZlcnMgd2FzIGV2ZXIKPiB1cGRhdGVk IHRvIHVzZSBpdC4gU2hvdWxkIHByb2JhYmx5IGRpc2FsbG93IGl0IHRvby4KPj4gKyAgICAgICAg ICAgICBicmVhazsKPj4gKyAgICAgZGVmYXVsdDoKPj4gKyAgICAgICAgICAgICBpZiAoIWRybV9j b3JlX2NoZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpCj4+ICsgICAgICAgICAgICAg ICAgICAgICByZXR1cm4gLUVOT1RTVVBQOwo+PiArICAgICB9Cj4KPiBBbmQgb25lIGNvZGUgb3Jn IGJpa2VzaGVkOiBJIGRvbid0IGxpa2UgdGhlIGR1cGxpY2F0ZWQgc3dpdGNoLCBjb3VsZCB3ZQo+ IGluc3RlYWQgc3BsaXQgaXQgaXQgaW50byB0d28gZGlzam9pbnQgc2V0cyBsaWtlIHRoaXM/Cj4K PiAgICAgICAgIHN3aXRjaCAocmVxLT5jYXBhYmlsaXR5KSB7Cj4gICAgICAgICBjYXNlIERSTV9D QVBfUFJJTUU6Cj4gICAgICAgICAgICAgICAgIHJlcS0+dmFsdWUgfD0gZGV2LT5kcml2ZXItPnBy aW1lX2ZkX3RvX2hhbmRsZSA/IERSTV9QUklNRV9DQVBfSU1QT1JUIDogMDsKPiAgICAgICAgICAg ICAgICAgcmVxLT52YWx1ZSB8PSBkZXYtPmRyaXZlci0+cHJpbWVfaGFuZGxlX3RvX2ZkID8gRFJN X1BSSU1FX0NBUF9FWFBPUlQgOiAwOwo+ICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAg IC4uLiBhbGwgb3RoZXIgbm9uLW1vZGVzZXQgY2FwcyAuLi4KPiAgICAgICAgIH0KPgo+ICAgICAg ICAgaWYgKCFkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKQo+ICAg ICAgICAgICAgICAgICByZXR1cm4gLUVOT1RTVVBQOwo+Cj4gICAgICAgICBzd2l0Y2ggKHJlcS0+ Y2FwYWJpbGl0eSkgewo+ICAgICAgICAgLi4uIGhhbmRsZSByZW1haW5pbmcgY2FwcyBuZWVkZWQg Zm9yIERSSVZFUl9NT0RTRVQgLi4uCj4gICAgICAgICBkZWZhdWx0Ogo+ICAgICAgICAgICAgICAg ICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgIH0KPgo+IFRoYXQgd2F5IGl0IHdvdWxkIGJlIGEg Yml0IG1vcmUgb2J2aW91cyB0aGF0IHBlb3BsZSB3aG8gYWRkIGEgbmV3IGNhcCBuZWVkCj4gdG8g bWFrZSBhIGRlY2lzaW9uIHdoZXJlIHRvIHB1dCBpdCAoYW5kIGJ5IGRlZmF1bHQgcHV0IGl0IGlu IHRoZSBib3R0b20KPiBwaWxlKS4KPiAtRGFuaWVsCj4KPj4gICAgICAgc3dpdGNoIChyZXEtPmNh cGFiaWxpdHkpIHsKPj4gICAgICAgY2FzZSBEUk1fQ0FQX0RVTUJfQlVGRkVSOgo+PiAgICAgICAg ICAgICAgIGlmIChkZXYtPmRyaXZlci0+ZHVtYl9jcmVhdGUpCj4+IEBAIC0yNTQsMTIgKzI2Nywx MCBAQCBzdGF0aWMgaW50IGRybV9nZXRjYXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAq ZGF0YSwgc3RydWN0IGRybV9maWxlICpmaWxlXwo+PiAgICAgICAgICAgICAgIHJlcS0+dmFsdWUg PSBkZXYtPm1vZGVfY29uZmlnLmFzeW5jX3BhZ2VfZmxpcDsKPj4gICAgICAgICAgICAgICBicmVh azsKPj4gICAgICAgY2FzZSBEUk1fQ0FQX1BBR0VfRkxJUF9UQVJHRVQ6Cj4+IC0gICAgICAgICAg ICAgaWYgKGRybV9jb3JlX2NoZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpIHsKPj4g LSAgICAgICAgICAgICAgICAgICAgIHJlcS0+dmFsdWUgPSAxOwo+PiAtICAgICAgICAgICAgICAg ICAgICAgZHJtX2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2KSB7Cj4+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlmICghY3J0Yy0+ZnVuY3MtPnBhZ2VfZmxpcF90YXJnZXQpCj4+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVxLT52YWx1ZSA9IDA7Cj4+IC0gICAg ICAgICAgICAgICAgICAgICB9Cj4+ICsgICAgICAgICAgICAgcmVxLT52YWx1ZSA9IDE7Cj4+ICsg ICAgICAgICAgICAgZHJtX2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2KSB7Cj4+ICsgICAgICAgICAg ICAgICAgICAgICBpZiAoIWNydGMtPmZ1bmNzLT5wYWdlX2ZsaXBfdGFyZ2V0KQo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByZXEtPnZhbHVlID0gMDsKPj4gICAgICAgICAgICAgICB9 Cj4+ICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICAgICAgIGNhc2UgRFJNX0NBUF9DVVJTT1JfV0lE VEg6Cj4+IC0tCj4+IDIuMTAuMgo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPgo+IC0tCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwg bWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=