From: Alex Deucher <alexdeucher@gmail.com>
To: Michele Curti <michele.curti@gmail.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: drm/radeon/combios: declare legacy_connector_convert as static
Date: Tue, 23 Sep 2014 23:17:56 -0400 [thread overview]
Message-ID: <CADnq5_N6R5Kxo1QOBq-daj_0N9b28JMHp7YiP7gDZnx9iZPv6Q@mail.gmail.com> (raw)
In-Reply-To: <20140923160440.GA24712@powerline.azcom-win.it>
On Tue, Sep 23, 2014 at 12:04 PM, Michele Curti <michele.curti@gmail.com> wrote:
>
> legacy_connector_convert is used in radeon_combios.c only, so declare it as static.
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
Applied both patches. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
> index 6651177..3e5f6b7 100644
> --- a/drivers/gpu/drm/radeon/radeon_combios.c
> +++ b/drivers/gpu/drm/radeon/radeon_combios.c
> @@ -116,7 +116,7 @@ enum radeon_combios_connector {
> CONNECTOR_UNSUPPORTED_LEGACY
> };
>
> -const int legacy_connector_convert[] = {
> +static const int legacy_connector_convert[] = {
> DRM_MODE_CONNECTOR_Unknown,
> DRM_MODE_CONNECTOR_DVID,
> DRM_MODE_CONNECTOR_VGA,
> --
> 2.1.0
>
> Regards,
> Michele
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-09-24 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 16:04 drm/radeon/combios: declare legacy_connector_convert as static Michele Curti
2014-09-24 3:17 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_N6R5Kxo1QOBq-daj_0N9b28JMHp7YiP7gDZnx9iZPv6Q@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=michele.curti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).