From: Alex Deucher <alexdeucher@gmail.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: only init fbdev if we have connectors
Date: Tue, 26 Jan 2016 00:36:23 -0500 [thread overview]
Message-ID: <CADnq5_Nk-2fEioFBgYV1QfGJMyg3eRFoiSm7hnEoEpdg0a8o5w@mail.gmail.com> (raw)
In-Reply-To: <1453763208-13095-1-git-send-email-robdclark@gmail.com>
On Mon, Jan 25, 2016 at 6:06 PM, Rob Clark <robdclark@gmail.com> wrote:
> This fixes an issue that was noticed on an optimus/prime laptop with
> a kernel that was old enough to not support the integrated intel gfx
> (which was driving all the outputs), but did have support for the
> discrete radeon gpu. The end result was not falling back to VESA and
> leaving the user with a black screen.
>
> (Plus it is kind of silly to create an framebuffer device if there
> are no outputs hooked up to the gpu.)
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 1eca0ac..f8e776c 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1670,8 +1670,10 @@ int radeon_modeset_init(struct radeon_device *rdev)
> /* setup afmt */
> radeon_afmt_init(rdev);
>
> - radeon_fbdev_init(rdev);
> - drm_kms_helper_poll_init(rdev->ddev);
> + if (!list_empty(&rdev->ddev->mode_config.connector_list)) {
> + radeon_fbdev_init(rdev);
> + drm_kms_helper_poll_init(rdev->ddev);
> + }
>
> /* do pm late init */
> ret = radeon_pm_late_init(rdev);
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-01-26 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 23:06 [PATCH] drm/radeon: only init fbdev if we have connectors Rob Clark
2016-01-25 23:57 ` Mike Lothian
2016-01-26 0:49 ` Rob Clark
2016-01-26 5:34 ` Alex Deucher
2016-01-26 5:36 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Nk-2fEioFBgYV1QfGJMyg3eRFoiSm7hnEoEpdg0a8o5w@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).