Re: [PATCH 02/32] drm/radeon: Add local 'fb' variables

[Alex Deucher <alexdeucher@gmail.com>]

On Thu, Nov 17, 2016 at 11:14 AM,  <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Add a local 'fb' variable to a few places to get rid of the
> 'crtc->primary->fb' stuff. Looks neater and helps me with my poor
> coccinelle skills later.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/radeon/r100.c               | 10 ++++++++--
>  drivers/gpu/drm/radeon/radeon_legacy_crtc.c |  3 ++-
>  2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> index f5e84f4b58e6..984b35f43554 100644
> --- a/drivers/gpu/drm/radeon/r100.c
> +++ b/drivers/gpu/drm/radeon/r100.c
> @@ -3225,13 +3225,19 @@ void r100_bandwidth_update(struct radeon_device *rdev)
>         radeon_update_display_priority(rdev);
>
>         if (rdev->mode_info.crtcs[0]->base.enabled) {
> +               const struct drm_framebuffer *fb =
> +                       rdev->mode_info.crtcs[0]->base.primary->fb;
> +
>                 mode1 = &rdev->mode_info.crtcs[0]->base.mode;
> -               pixel_bytes1 = rdev->mode_info.crtcs[0]->base.primary->fb->bits_per_pixel / 8;
> +               pixel_bytes1 = fb->bits_per_pixel / 8;
>         }
>         if (!(rdev->flags & RADEON_SINGLE_CRTC)) {
>                 if (rdev->mode_info.crtcs[1]->base.enabled) {
> +                       const struct drm_framebuffer *fb =
> +                               rdev->mode_info.crtcs[1]->base.primary->fb;
> +
>                         mode2 = &rdev->mode_info.crtcs[1]->base.mode;
> -                       pixel_bytes2 = rdev->mode_info.crtcs[1]->base.primary->fb->bits_per_pixel / 8;
> +                       pixel_bytes2 = fb->bits_per_pixel / 8;
>                 }
>         }
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
> index d0de4022fff9..bb5346812de4 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
> @@ -579,6 +579,7 @@ static bool radeon_set_crtc_timing(struct drm_crtc *crtc, struct drm_display_mod
>         struct drm_device *dev = crtc->dev;
>         struct radeon_device *rdev = dev->dev_private;
>         struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
> +       const struct drm_framebuffer *fb = crtc->primary->fb;
>         struct drm_encoder *encoder;
>         int format;
>         int hsync_start;
> @@ -602,7 +603,7 @@ static bool radeon_set_crtc_timing(struct drm_crtc *crtc, struct drm_display_mod
>                 }
>         }
>
> -       switch (crtc->primary->fb->bits_per_pixel) {
> +       switch (fb->bits_per_pixel) {
>         case 8:
>                 format = 2;
>                 break;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel