Re: [pull] radeon drm-fixes-3.12

[Alex Deucher <alexdeucher@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Thu, Oct 10, 2013 at 10:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> 2013/10/10 Alex Deucher <alexdeucher@gmail.com>:
>> On Thu, Oct 10, 2013 at 1:39 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>>> 2013/10/10 Alex Deucher <alexdeucher@gmail.com>:
>>>>       drm/radeon: use hw generated CTS/N values for audio
>>>
>>> I'd like to see such patches earlier :| I'm OK with the change for
>>> DCE4+ (Evergreen) (I even suggested that change myself recently), but
>>> I didn't have time to check how this should be programmed on
>>> DCE2/3/4...
>>>
>>> In your patch 0001-WIP-port-of-hdmi-dp-audio-code-to-newer-kernel.patch
>>> based on (AFAIU) internal specs you were setting HDMI_ACR_SOURCE.
>>>
>>> According to the Christian R6xx may really have some bug for
>>> generating values by the hw, see:
>>> https://bugs.freedesktop.org/show_bug.cgi?id=69675#c12
>>>
>>> So it doesn't look like a good patch for -fixes, especially without
>>> testing it on some hardware.
>>
>> Yeah, I thought about that, but on the other hand, there is already a
>> regression caused by the 1001 modes patches that this series fixes.  I
>> can add a patch to disable the hw generated values on older families
>> for now if you'd prefer.
>
> It would be nice. I'm working on getting some old GPUs, tracing fglrx
> and testing. So I hope to get HDMI support on DCE2/3 cleaned soon.

Attached.  I'll send an updated pull request with the patch added.

Alex

[-- Attachment #2: 0001-drm-radeon-re-enable-sw-ACR-support-on-pre-DCE4.patch --]
[-- Type: application/octet-stream, Size: 1178 bytes --]

From b852c985010a77c850b7548d64bbb964ca462b02 Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexander.deucher@amd.com>
Date: Thu, 10 Oct 2013 11:47:01 -0400
Subject: [PATCH] drm/radeon: re-enable sw ACR support on pre-DCE4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

HW ACR support may have issues on some older chips, so
use SW ACR for now until we've tested further.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
CC: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/gpu/drm/radeon/r600_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c
index e2ae1c2..5b72931 100644
--- a/drivers/gpu/drm/radeon/r600_hdmi.c
+++ b/drivers/gpu/drm/radeon/r600_hdmi.c
@@ -451,6 +451,7 @@ void r600_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *mod
 	}
 
 	WREG32(HDMI0_ACR_PACKET_CONTROL + offset,
+	       HDMI0_ACR_SOURCE | /* select SW CTS value - XXX verify that hw CTS works on all families */
 	       HDMI0_ACR_AUTO_SEND); /* allow hw to sent ACR packets when required */
 
 	WREG32(HDMI0_VBI_PACKET_CONTROL + offset,
-- 
1.8.3.1


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel