dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Egbert Eich <eich@suse.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips.
Date: Wed, 24 Oct 2012 12:57:19 -0400	[thread overview]
Message-ID: <CADnq5_OTAAEacdntOicCFnmehKKLSXQ39S_Zm3y0Uh4jkF-yhg@mail.gmail.com> (raw)
In-Reply-To: <1351096279-5710-1-git-send-email-eich@suse.de>

On Wed, Oct 24, 2012 at 12:31 PM, Egbert Eich <eich@suse.de> wrote:
> For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
> works better on ES1000 (RV100) chips, too, as it doesn't produce any false
> positives on any cards I have tested. Therefore let's assume that this
> value is good for all RV100 and RV200 chipset generations.

Looks good.  Added to by -fixes queue.

Thanks!

Alex

>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
>  drivers/gpu/drm/radeon/radeon_legacy_encoders.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 752e98b..c7916ac 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -659,6 +659,8 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
>
>         if (ASIC_IS_R300(rdev))
>                 tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
> +       else if (ASIC_IS_RV100(rdev))
> +               tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT);
>         else
>                 tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);
>
> --
> 1.7.6.3
>

      reply	other threads:[~2012-10-24 16:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 16:31 [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips Egbert Eich
2012-10-24 16:57 ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_OTAAEacdntOicCFnmehKKLSXQ39S_Zm3y0Uh4jkF-yhg@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eich@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).