* [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips.
@ 2012-10-24 16:31 Egbert Eich
2012-10-24 16:57 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Egbert Eich @ 2012-10-24 16:31 UTC (permalink / raw)
To: dri-devel; +Cc: Egbert Eich
For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
works better on ES1000 (RV100) chips, too, as it doesn't produce any false
positives on any cards I have tested. Therefore let's assume that this
value is good for all RV100 and RV200 chipset generations.
Signed-off-by: Egbert Eich <eich@suse.de>
---
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index 752e98b..c7916ac 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -659,6 +659,8 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
if (ASIC_IS_R300(rdev))
tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
+ else if (ASIC_IS_RV100(rdev))
+ tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT);
else
tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);
--
1.7.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips.
2012-10-24 16:31 [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips Egbert Eich
@ 2012-10-24 16:57 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2012-10-24 16:57 UTC (permalink / raw)
To: Egbert Eich; +Cc: dri-devel
On Wed, Oct 24, 2012 at 12:31 PM, Egbert Eich <eich@suse.de> wrote:
> For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
> works better on ES1000 (RV100) chips, too, as it doesn't produce any false
> positives on any cards I have tested. Therefore let's assume that this
> value is good for all RV100 and RV200 chipset generations.
Looks good. Added to by -fixes queue.
Thanks!
Alex
>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 752e98b..c7916ac 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -659,6 +659,8 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
>
> if (ASIC_IS_R300(rdev))
> tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
> + else if (ASIC_IS_RV100(rdev))
> + tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT);
> else
> tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);
>
> --
> 1.7.6.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-24 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 16:31 [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips Egbert Eich
2012-10-24 16:57 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).