From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips. Date: Wed, 24 Oct 2012 12:57:19 -0400 Message-ID: References: <1351096279-5710-1-git-send-email-eich@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DB8D9E9D9 for ; Wed, 24 Oct 2012 09:57:20 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u50so363034wey.36 for ; Wed, 24 Oct 2012 09:57:19 -0700 (PDT) In-Reply-To: <1351096279-5710-1-git-send-email-eich@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Egbert Eich Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Oct 24, 2012 at 12:31 PM, Egbert Eich wrote: > For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value > works better on ES1000 (RV100) chips, too, as it doesn't produce any false > positives on any cards I have tested. Therefore let's assume that this > value is good for all RV100 and RV200 chipset generations. Looks good. Added to by -fixes queue. Thanks! Alex > > Signed-off-by: Egbert Eich > --- > drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > index 752e98b..c7916ac 100644 > --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > @@ -659,6 +659,8 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc > > if (ASIC_IS_R300(rdev)) > tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT); > + else if (ASIC_IS_RV100(rdev)) > + tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT); > else > tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT); > > -- > 1.7.6.3 >