dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [pull] radeon drm-fixes-3.12
Date: Thu, 10 Oct 2013 10:46:12 -0400	[thread overview]
Message-ID: <CADnq5_OYtsjWGuWe2morD-qEYPdgs_aijgqN_BYixr7acWT_oA@mail.gmail.com> (raw)
In-Reply-To: <CACna6rwZ-_cUr-1OYn_4JZO65ec=WWZHLB5bu2pVpP1JoUwzQA@mail.gmail.com>

On Thu, Oct 10, 2013 at 1:39 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> 2013/10/10 Alex Deucher <alexdeucher@gmail.com>:
>>       drm/radeon: use hw generated CTS/N values for audio
>
> I'd like to see such patches earlier :| I'm OK with the change for
> DCE4+ (Evergreen) (I even suggested that change myself recently), but
> I didn't have time to check how this should be programmed on
> DCE2/3/4...
>
> In your patch 0001-WIP-port-of-hdmi-dp-audio-code-to-newer-kernel.patch
> based on (AFAIU) internal specs you were setting HDMI_ACR_SOURCE.
>
> According to the Christian R6xx may really have some bug for
> generating values by the hw, see:
> https://bugs.freedesktop.org/show_bug.cgi?id=69675#c12
>
> So it doesn't look like a good patch for -fixes, especially without
> testing it on some hardware.

Yeah, I thought about that, but on the other hand, there is already a
regression caused by the 1001 modes patches that this series fixes.  I
can add a patch to disable the hw generated values on older families
for now if you'd prefer.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2013-10-10 14:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 22:10 [pull] radeon drm-fixes-3.12 Alex Deucher
2013-10-10  5:39 ` Rafał Miłecki
2013-10-10 14:46   ` Alex Deucher [this message]
2013-10-10 14:50     ` Rafał Miłecki
2013-10-10 15:56       ` Alex Deucher
2013-10-10 16:22         ` Rafał Miłecki
2013-10-10 17:15 ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2013-10-25 13:50 Alex Deucher
2013-10-19 13:55 Alex Deucher
2013-09-25 22:57 Alex Deucher
2013-09-16  1:03 Alex Deucher
2013-09-11 19:58 Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_OYtsjWGuWe2morD-qEYPdgs_aijgqN_BYixr7acWT_oA@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).