* [PATCH] drm/amd/display: Remove redundant header files
@ 2025-08-19 14:24 Liao Yuanhong
2025-08-19 14:58 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Liao Yuanhong @ 2025-08-19 14:24 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, David Airlie, Simona Vetter, Alex Hung,
Aric Cyr, Taimur Hassan, Aurabindo Pillai, Dillon Varone,
Yihan Zhu, Muhammad Ahmed, George Shen, Reza Amini, Cruise Hung,
open list:AMD DISPLAY CORE, open list:DRM DRIVERS, open list
Cc: Liao Yuanhong
The header file "dc_stream.h" is already included on line 1507. Remove the
redundant include.
This is because the header file was initially included towards the latter
part of the code. Subsequent commits had to include the header file again
earlier in the code. In my opinion, this doesn't count as a fix; it just
requires removing the redundant header inclusion.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 1ab05eabbddb..2ceaf861edb9 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -1854,8 +1854,6 @@ void dc_3dlut_func_retain(struct dc_3dlut *lut);
void dc_post_update_surfaces_to_stream(
struct dc *dc);
-#include "dc_stream.h"
-
/**
* struct dc_validation_set - Struct to store surface/stream associations for validation
*/
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Remove redundant header files
2025-08-19 14:24 [PATCH] drm/amd/display: Remove redundant header files Liao Yuanhong
@ 2025-08-19 14:58 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2025-08-19 14:58 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, David Airlie, Simona Vetter, Alex Hung,
Aric Cyr, Taimur Hassan, Aurabindo Pillai, Dillon Varone,
Yihan Zhu, Muhammad Ahmed, George Shen, Reza Amini, Cruise Hung,
open list:AMD DISPLAY CORE, open list:DRM DRIVERS, open list
Applied. Thanks!
On Tue, Aug 19, 2025 at 10:33 AM Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
>
> The header file "dc_stream.h" is already included on line 1507. Remove the
> redundant include.
>
> This is because the header file was initially included towards the latter
> part of the code. Subsequent commits had to include the header file again
> earlier in the code. In my opinion, this doesn't count as a fix; it just
> requires removing the redundant header inclusion.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 1ab05eabbddb..2ceaf861edb9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -1854,8 +1854,6 @@ void dc_3dlut_func_retain(struct dc_3dlut *lut);
> void dc_post_update_surfaces_to_stream(
> struct dc *dc);
>
> -#include "dc_stream.h"
> -
> /**
> * struct dc_validation_set - Struct to store surface/stream associations for validation
> */
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-19 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 14:24 [PATCH] drm/amd/display: Remove redundant header files Liao Yuanhong
2025-08-19 14:58 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).