From: Alex Deucher <alexdeucher@gmail.com>
To: Christian Koenig <christian.koenig@amd.com>
Cc: Joe Perches <joe@perches.com>, David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Colin King <colin.king@canonical.com>
Subject: Re: [PATCH] drm/ttm: Use a static string instead of an array of char *
Date: Tue, 28 Nov 2017 15:49:51 -0500 [thread overview]
Message-ID: <CADnq5_Pa401vrz++kTL52rJwpsB-XOLvNsmsY2jP7bnWWxS2hw@mail.gmail.com> (raw)
In-Reply-To: <0ab8a8c7-71a5-21a5-992f-45c79ab24f4c@gmail.com>
On Tue, Nov 28, 2017 at 2:37 PM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 28.11.2017 um 20:34 schrieb Joe Perches:
>>
>> Make the object a bit smaller by using a simple string instead
>> of a format string and array of char *.
>>
>> $ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o*
>> text data bss dec hex filename
>> 8820 216 4136 13172 3374
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new
>> 8910 216 4136 13262 33ce
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.old
>> 25383 5044 4384 34811 87fb
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.new
>> 25797 5428 4384 35609 8b19
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.old
>>
>> Miscellanea:
>>
>> o The h array had more entries than were emitted, all are now removed
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Applied. thanks!
Alex
>
>> ---
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> index 6b2627fe9bc1..bda00b2ab51c 100644
>> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> @@ -1244,15 +1244,12 @@ int ttm_dma_page_alloc_debugfs(struct seq_file *m,
>> void *data)
>> {
>> struct device_pools *p;
>> struct dma_pool *pool = NULL;
>> - char *h[] = {"pool", "refills", "pages freed", "inuse",
>> "available",
>> - "name", "virt", "busaddr"};
>> if (!_manager) {
>> seq_printf(m, "No pool allocator running.\n");
>> return 0;
>> }
>> - seq_printf(m, "%13s %12s %13s %8s %8s %8s\n",
>> - h[0], h[1], h[2], h[3], h[4], h[5]);
>> + seq_printf(m, " pool refills pages freed inuse
>> available name\n");
>> mutex_lock(&_manager->lock);
>> list_for_each_entry(p, &_manager->pools, pools) {
>> struct device *dev = p->dev;
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-11-28 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 19:34 [PATCH] drm/ttm: Use a static string instead of an array of char * Joe Perches
2017-11-28 19:37 ` Christian König
2017-11-28 20:49 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Pa401vrz++kTL52rJwpsB-XOLvNsmsY2jP7bnWWxS2hw@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).