From: Alex Deucher <alexdeucher@gmail.com>
To: sunran001@208suo.com
Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
Date: Mon, 24 Jul 2023 17:49:36 -0400 [thread overview]
Message-ID: <CADnq5_PgmnmoNRoePzH1_DShKv8qJt8KVcZGGEqO+wu10VdYnA@mail.gmail.com> (raw)
In-Reply-To: <d6c3b91864b9f3f90d8a2d3cd952bada@208suo.com>
Applied. Thanks!
On Mon, Jul 24, 2023 at 3:49 AM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 3ecb900e6ecd..b26e9ac1ac30 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context
> *smu,
>
> #undef __SMU_DUMMY_MAP
> #define __SMU_DUMMY_MAP(fea) #fea
> -static const char* __smu_feature_names[] = {
> +static const char *__smu_feature_names[] = {
> SMU_FEATURE_MASKS
> };
>
> @@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context
> *smu,
> void *metrics_table,
> bool bypass_cache)
> {
> - struct smu_table_context *smu_table= &smu->smu_table;
> + struct smu_table_context *smu_table = &smu->smu_table;
> uint32_t table_size =
> smu_table->tables[SMU_TABLE_SMU_METRICS].size;
> int ret = 0;
> @@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table,
> uint8_t frev, uint8_t crev)
> struct metrics_table_header *header = (struct metrics_table_header
> *)table;
> uint16_t structure_size;
>
> -#define METRICS_VERSION(a, b) ((a << 16) | b )
> +#define METRICS_VERSION(a, b) ((a << 16) | b)
>
> switch (METRICS_VERSION(frev, crev)) {
> case METRICS_VERSION(1, 0):
next prev parent reply other threads:[~2023-07-24 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230724074800.9099-1-xujianghui@cdjrlc.com>
2023-07-24 7:49 ` [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c sunran001
2023-07-24 21:49 ` Alex Deucher [this message]
[not found] <20230724073153.9003-1-xujianghui@cdjrlc.com>
2023-07-24 7:32 ` sunran001
2023-07-24 21:48 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_PgmnmoNRoePzH1_DShKv8qJt8KVcZGGEqO+wu10VdYnA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunran001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).