From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay kumar Subject: Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge Date: Tue, 28 Oct 2014 20:16:44 +0530 Message-ID: References: <1409149783-12416-1-git-send-email-ajaykumar.rs@samsung.com> <1409149783-12416-4-git-send-email-ajaykumar.rs@samsung.com> <20141027190137.GT26941@phenom.ffwll.local> <20141028144126.GC17770@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20141028144126.GC17770@ulmo> Sender: linux-samsung-soc-owner@vger.kernel.org To: Thierry Reding Cc: Daniel Vetter , Sean Paul , Ajay Kumar , dri-devel , linux-samsung-soc , InKi Dae , Rob Clark , Jingoo Han , Prashanth G , Pannaga Bhushan Reddy Patel List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 28, 2014 at 8:11 PM, Thierry Reding wrote: > On Tue, Oct 28, 2014 at 03:19:36PM +0100, Daniel Vetter wrote: >> On Tue, Oct 28, 2014 at 1:28 PM, Ajay kumar wrote: >> > On Tue, Oct 28, 2014 at 3:31 PM, Daniel Vetter wrote: > [...] >> >> Hm, if you do this can you pls also update drm_panel accordingly? It >> >> shouldn't be a lot of fuzz and would make things around drm+dt more >> >> consistent. >> > Are you talking about using struct device_node instead of struct device? >> > I guess you have misplaced the comment under the wrong section! >> >> Yeah, that should have been one up ;-) > > Like I said earlier, I don't think dropping struct device * in favour of > struct device_node * is a good idea. I am not sure about drm_panel. But, I am not really doing anything with the struct device pointer in case of bridge. So, just wondering if it is really needed? Ajay