Re: [RFC 0/1] drm: Add Grain Media GM12U320 kms driver

From: "Marco Diego Aurélio Mesquita" <marcodiegomesquita@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [RFC 0/1] drm: Add Grain Media GM12U320 kms driver
Date: Thu, 1 Jun 2017 19:46:36 -0300	[thread overview]
Message-ID: <CAE_m23nw6Xo2R8E6G3L8srd0rrtc1j4ULrs_e3KGPObjzVxW_Q@mail.gmail.com> (raw)
In-Reply-To: <20170601115934.4265-1-hdegoede@redhat.com>

Hi Devs!

On Thu, Jun 1, 2017 at 8:59 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi All,
>
> This is a resend of a patch I send out a while back, rebased on top
> of 4.12-rc3. Back then the main comment was can you try to make this
> driver use the drm_simple_kms_helper stuff? Unfortunately I have
> not had time yet to look into this.
>
> Recently I've been contacted by Marco Diego Aurélio Mesquita (in the Cc)
> who wants to work on getting this driver ready for mainline.
>
> He has has some questions / ideas about how to do this, so the
> main reason for reposting this is to give him a thread to reply to
> which provides context for his questions / ideas.
>

Hans, thanks for citing me.

I'm an owner of a c120 miniprojector and would like to have this
driver on mainline. As far as I could test (previous versions) it
works reasonably well. From what I've seen[1], main obstacle for this
driver been mainlined is the duplicated code from the udl driver.

I've been playing with the code of this driver for a few days and I
think that moving the common code between the udl and gm12u320 is a
sound idea. It would greatly simplify the code of both drivers and
both would become much smaller.

Since I'm a coder myself, I would like to do it myself. Common code
and differences from both drivers are very easy to spot and moving
that into a common lib is something that I think a can do without any
problems. The only reason I still have not started it is because I
don't know if such work would be accepted.

So, my question for you devs is: do you agree in factoring out some
code from the udl driver so that both drivers (udl and gm12u320) can
be smaller and simpler?

If the answer to this question is yes, then I'll start coding and plan
to comeback just to ask about minor details about what is really
specific (even if equal) for any driver and what is not.

Hope you agree with my proposal.

When answering, please cc me as I'm not subscribed to the list.

Thanks!

[1] https://lists.freedesktop.org/archives/dri-devel/2016-June/109648.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel