* [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails
@ 2016-11-30 11:48 Lucas Stach
2016-12-01 4:26 ` Archit Taneja
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2016-11-30 11:48 UTC (permalink / raw)
To: Archit Taneja; +Cc: kernel, dri-devel, patchwork-lst
ASSR is an optional feature, so it's a valid operating condition for
the display to reject ASSR enable. Demote the warning to the debug
level.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/gpu/drm/bridge/tc358767.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 44d476ea6d2e..a7872400eed8 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -908,7 +908,7 @@ static int tc_main_link_setup(struct tc_data *tc)
goto err_dpcd_read;
if (tmp[0] != tc->assr) {
- dev_warn(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
+ dev_dbg(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
tc->assr);
/* trying with disabled scrambler */
tc->link.scrambler_dis = 1;
--
2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails
2016-11-30 11:48 [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails Lucas Stach
@ 2016-12-01 4:26 ` Archit Taneja
2016-12-01 7:58 ` Philipp Zabel
0 siblings, 1 reply; 4+ messages in thread
From: Archit Taneja @ 2016-12-01 4:26 UTC (permalink / raw)
To: Lucas Stach; +Cc: Andrey Gusakov, kernel, dri-devel
On 11/30/2016 05:18 PM, Lucas Stach wrote:
> ASSR is an optional feature, so it's a valid operating condition for
> the display to reject ASSR enable. Demote the warning to the debug
> level.
Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.
Thanks,
Archit
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 44d476ea6d2e..a7872400eed8 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -908,7 +908,7 @@ static int tc_main_link_setup(struct tc_data *tc)
> goto err_dpcd_read;
>
> if (tmp[0] != tc->assr) {
> - dev_warn(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
> + dev_dbg(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
> tc->assr);
> /* trying with disabled scrambler */
> tc->link.scrambler_dis = 1;
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails
2016-12-01 4:26 ` Archit Taneja
@ 2016-12-01 7:58 ` Philipp Zabel
2016-12-01 9:40 ` Andrey Gusakov
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Zabel @ 2016-12-01 7:58 UTC (permalink / raw)
To: Archit Taneja; +Cc: Andrey Gusakov, kernel, dri-devel
Am Donnerstag, den 01.12.2016, 09:56 +0530 schrieb Archit Taneja:
>
> On 11/30/2016 05:18 PM, Lucas Stach wrote:
> > ASSR is an optional feature, so it's a valid operating condition for
> > the display to reject ASSR enable. Demote the warning to the debug
> > level.
>
> Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.
No objections, this message is not helpful to a normal user.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails
2016-12-01 7:58 ` Philipp Zabel
@ 2016-12-01 9:40 ` Andrey Gusakov
0 siblings, 0 replies; 4+ messages in thread
From: Andrey Gusakov @ 2016-12-01 9:40 UTC (permalink / raw)
To: Philipp Zabel; +Cc: kernel, dri-devel
Hi.
I'm fine with that change.
Acked-by:Andrey Gusakov <andrey.gusakov@cogentembedded.com>
On Thu, Dec 1, 2016 at 10:58 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Am Donnerstag, den 01.12.2016, 09:56 +0530 schrieb Archit Taneja:
>>
>> On 11/30/2016 05:18 PM, Lucas Stach wrote:
>> > ASSR is an optional feature, so it's a valid operating condition for
>> > the display to reject ASSR enable. Demote the warning to the debug
>> > level.
>>
>> Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.
>
> No objections, this message is not helpful to a normal user.
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> regards
> Philipp
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-01 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 11:48 [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails Lucas Stach
2016-12-01 4:26 ` Archit Taneja
2016-12-01 7:58 ` Philipp Zabel
2016-12-01 9:40 ` Andrey Gusakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).