Re: [PATCH RFC 12/24] drm/lima: add GP related functions

From: Qiang Yu <yuq825@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Simon Shields <simon@lineageos.org>,
	devicetree@vger.kernel.org, Connor Abbott <cwabbott0@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Andrei Paulau <7134956@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Erico Nunes <nunes.erico@gmail.com>
Subject: Re: [PATCH RFC 12/24] drm/lima: add GP related functions
Date: Thu, 24 May 2018 08:38:31 +0800	[thread overview]
Message-ID: <CAKGbVbsE7N=C3OwpFEQOmmD1urqWNbC-1hZiHGphiM8C6A4HXQ@mail.gmail.com> (raw)
In-Reply-To: <7b42a0c2-3737-327c-3829-0c322497b317@denx.de>

On Thu, May 24, 2018 at 1:12 AM, Marek Vasut <marex@denx.de> wrote:
> On 05/18/2018 11:28 AM, Qiang Yu wrote:
>> GP is a processor for OpenGL vertex shader
>> processing.
>>
>> Signed-off-by: Qiang Yu <yuq825@gmail.com>
>
> [...]
>
>> +int lima_gp_init(struct lima_ip *ip)
>> +{
>> +     struct lima_device *dev = ip->dev;
>> +     int err;
>> +
>> +     lima_gp_print_version(ip);
>> +
>> +     ip->data.async_reset = false;
>> +     lima_gp_soft_reset_async(ip);
>> +     err = lima_gp_soft_reset_async_wait(ip);
>> +     if (err)
>> +             return err;
>> +
>> +     err = devm_request_irq(dev->dev, ip->irq, lima_gp_irq_handler, 0,
>> +                            lima_ip_name(ip), ip);
>
> IRQF_SHARED, since there are designs (like zynqmp) where there is only
> one IRQ line for the entire GPU.

Right, will add this flag.

Regards,
Qiang

>
>> +     if (err) {
>> +             dev_err(dev->dev, "gp %s fail to request irq\n",
>> +                     lima_ip_name(ip));
>> +             return err;
>> +     }
>> +
>> +     return 0;
>> +}
>
>
> [...]
>
> --
> Best regards,
> Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel