From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrik Jakobsson Subject: Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers Date: Tue, 8 Oct 2013 22:22:52 +0200 Message-ID: References: <1375897287-8787-1-git-send-email-robdclark@gmail.com> <1375897287-8787-8-git-send-email-robdclark@gmail.com> <20131008195754.GA2010@thor.baobob.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A06BBE6E33 for ; Tue, 8 Oct 2013 13:30:06 -0700 (PDT) Received: by mail-la0-f54.google.com with SMTP id ea20so7317774lab.41 for ; Tue, 08 Oct 2013 13:30:05 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 8, 2013 at 10:19 PM, Rob Clark wrote: > On Tue, Oct 8, 2013 at 3:57 PM, Guillaume CL=C9MENT = wrote: >> On Wed, Aug 07, 2013 at 01:41:25PM -0400, Rob Clark wrote: >>> Signed-off-by: Rob Clark >>> --- >>> drivers/gpu/drm/gma500/gtt.c | 38 ++++++------------------------------= -- >>> 1 file changed, 6 insertions(+), 32 deletions(-) >>> [ snip ] >> >> This is quite late to report, but I've just begun testing 3.12, and this >> patch makes my screen garbled when using the modesetting xorg driver. >> >> So far it looks like the buffer that the xorg driver gets is >> not the one that is actually mapped by the kernel. >> >> I'm currently trying to know what exactly causes the problem, but I don't >> know anything about the internals here... >> > > could you try this small patch.. I think I missed something w/ my > original patch (sorry, no hw to test on here): > > ---------- > diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c > index 92babac..2db731f 100644 > --- a/drivers/gpu/drm/gma500/gtt.c > +++ b/drivers/gpu/drm/gma500/gtt.c > @@ -204,6 +204,7 @@ static int psb_gtt_attach_pages(struct gtt_range *gt) > if (IS_ERR(pages)) > return PTR_ERR(pages); > > + gt->npage =3D gt->gem.size / PAGE_SIZE; > gt->pages =3D pages; > > return 0; > ---------- > Rob, if this works, can you please make sure it goes into Dave's tree. I'm currently travelling and I'll be away for at least one week. Thanks Patrik