Re: [PATCH v5 0/4] EFI fbcon fixes etc

[Ard Biesheuvel <ardb@kernel.org>]

On Tue, 9 Dec 2025 at 04:39, Tvrtko Ursulin <tursulin@igalia.com> wrote:
>
> From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>
> Two generic fixes split out for easy review, one refactoring as requested, and
> then the last patch is the panel/mode quirk to allow for corruption free fbcon
> with simpledrmfb and efidrmfb on the Valve Steam Deck.
>
> v2:
>  * s/unsigned/unsigned int/
>  * s/pitch/linelength/
>  * Removed comment explaining the Steam Deck quirk.
>  * Added patch to refactor quirk application via callbacks.
>
> v3:
>  * Added forgotten __initconst.
>  * Use separate callback for the fixup quirk.
>
> v4:
>  * Use __screen_info_lfb_bits_per_pixel() instead of accessing lfb_depth directly.
>
> v5:
>  * s/lfb_width/bpp/.
>  * Grammar and typo tidy in the last patch.
>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Melissa Wen <mwen@igalia.com>
> Cc: linux-efi@vger.kernel.org
>
> Tvrtko Ursulin (4):
>   efi: sysfb_efi: Replace open coded swap with the macro
>   efi: sysfb_efi: Fix lfb_linelength calculation when applying quirks
>   efi: sysfb_efi: Convert swap width and height quirk to a callback
>   efi: sysfb_efi: Fix efidrmfb and simpledrmfb on Valve Steam Deck
>
>  drivers/firmware/efi/sysfb_efi.c | 73 ++++++++++++++++++++++++++++----
>  1 file changed, 65 insertions(+), 8 deletions(-)
>

This looks fine to me now. Unless there are more comments, I intend to
get this queued up as soon as -rc1 comes around.

Thanks