From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 505C9C00140 for ; Thu, 18 Aug 2022 15:32:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6570414B47E; Thu, 18 Aug 2022 15:29:05 +0000 (UTC) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0BB514AF75 for ; Thu, 18 Aug 2022 15:28:22 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id g16so1340429qkl.11 for ; Thu, 18 Aug 2022 08:28:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=T9A28BLo2B0nLzuZtZ0Ejl0zLIHzqGciO6GeX7JAOrM=; b=z9KuZS3VzqwP4u+R3h84Q4Lkg/vTMQB67gYeDQyUP514guWHruk1E0n1sWnB57/wf7 zkHnOPrpzBYox/Xf3YxtbhuGklIsJc1Y6F9F532BiyxTGoqevPFwo0esyxStN4cHPoU7 RWWaraVGfrbKnwTlcLYzHg6wri89g2aZuCs8+faiRnsVJ6hxVid14jNEZzuFUOkEY0cB U6gOvrs3cn4Jdzq1M0V/4v7uyDjuq8IWHmPhPuavJQgT6+7hqEBVUf85KCpvv2+KlqgU TGomJRo6gKaUxzNFFM8tkHsDQmKeBBXn4HprpvuE8c3KYLZwgRlnirvPpXQi7T7yz4Bv R9PQ== X-Gm-Message-State: ACgBeo3tnHfmlcpIKgmIyLTyhUmW94/xwz2+VSOhxhevKnFlCjJtWuVZ NxRN07QIHK1kk1qh4uzSyRwcYgGs8Aq3NQ== X-Google-Smtp-Source: AA6agR4bwBJXdc4PWKY4uesn9FkmCA3EDpoB+akd3rOIJb8w6/R+F8U7o+T82guGVixK+35sGCmD6g== X-Received: by 2002:a05:620a:4609:b0:6bb:937d:b151 with SMTP id br9-20020a05620a460900b006bb937db151mr2560214qkb.359.1660836501468; Thu, 18 Aug 2022 08:28:21 -0700 (PDT) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id bp37-20020a05620a45a500b006b9c355ed75sm1616498qkb.70.2022.08.18.08.28.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 08:28:21 -0700 (PDT) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-334dc616f86so50358867b3.8 for ; Thu, 18 Aug 2022 08:28:21 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr3357401ybl.89.1660836055065; Thu, 18 Aug 2022 08:20:55 -0700 (PDT) MIME-Version: 1.0 References: <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> <20220817111454.pn2iltvyo2drebq7@houat> <20220817131854.jwmhqvhfhp77bbr3@houat> <20220818145436.vqojnhmvhjxdzooe@houat> In-Reply-To: <20220818145436.vqojnhmvhjxdzooe@houat> From: Geert Uytterhoeven Date: Thu, 18 Aug 2022 17:20:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , David Airlie , DRI Development , Phil Elwell , Jerome Brunet , Samuel Holland , Kevin Hilman , Jernej Skrabec , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Martin Blumenstingl , "open list:ARM/Amlogic Meson..." , Linux ARM , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , Mateusz Kwiatkowski , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On Thu, Aug 18, 2022 at 4:54 PM Maxime Ripard wrote: > On Wed, Aug 17, 2022 at 04:04:24PM +0200, Geert Uytterhoeven wrote: > > On Wed, Aug 17, 2022 at 3:19 PM Maxime Ripard wrote: > > > On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > > > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > > > > > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > > > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > > > > > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and "hd720p60"), or > > > > > > > > > > > > > > handle them through "@". The latter would impact "[PATCH v1 > > > > > > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separate function", as > > > > > > > > > > > > > > currently a named mode and a refresh rate can't be specified both. > > > > > > > > > > > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies a bit the > > > > > > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a > > > > > > > > > > > > > > command-line option" uses a separate "tv_mode" option, and not the main > > > > > > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mode hd720p50, > > > > > > > > > > > > > which would be equivalent to 1280x720,tv_mode=hd720p > > > > > > > > > > > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=hd720p"? > > > > > > > > > > > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=hd720p > > > > > > > > > > > > > > > > > > > > Above you said "I think the former would make more sense", so that > > > > > > > > > > should be "1280x720,tv_mode=hd720p50"? > > > > > > > > > > > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mode=hd720p > > > > > > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=hd720p > > > > > > > > > > > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > > > > > > > > > > > I agree, and I don't see how that command-line doesn't express that? > > > > > > > > > > > > Oh, I see what you mean: yes, it expresses that. > > > > > > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > > > > > > where the TV mode specifies both number of lines and frame rate. > > > > > > > > > > Only if we're using a named mode, and naming is hard :) > > > > > > > > That's not true: "640x480,tv_mode=PAL-N" would give me a mode with > > > > 625 lines and 25 frames/s, "640x480,tv_mode=PAL-M" would give me a > > > > mode with 525 lines and 30 frames/s. > > > > > > In that series, "640x480,tv_mode=PAL-N" would be rejected as invalid: > > > > > > https://lore.kernel.org/dri-devel/20220728-rpi-analog-tv-properties-v1-14-3d53ae722097@cerno.tech/ > > > > It would become supported once the ideas from thread "[PATCH v1 04/35] > > drm/modes: Introduce 480i and 576i modes" are implemented... > > Indeed, but I'm still not sure what your concern is here. > "640x480,tv_mode=PAL-N" and "640x480,tv_mode=PAL-M" are both fairly > obvious. > > You were initially saying that you had concern over the inconsistency of > NTSC/PAL/SECAM where the TV mode would specify a number of lines and > frame rate, but hd720p50 also specifies a number of line and frame rate? My concern is that you want to call the TV mode "hd720p", which does not dictate the frame rate. I would like to have both "720p50" and "720p60", as they do dictate the frame rate, like all the non-hd modes. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds