From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 3/3] drm: rcar-du: Convert rcar_du_encoders_init_one() return value to 0/<0 Date: Tue, 26 May 2015 21:24:03 +0200 Message-ID: References: <1432652516-15085-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1432652516-15085-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1432652516-15085-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: DRI Development , Linux-sh list , Cao Minh Hiep List-Id: dri-devel@lists.freedesktop.org On Tue, May 26, 2015 at 5:01 PM, Laurent Pinchart wrote: > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -640,14 +640,14 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, > of_node_put(connector); > > if (!ret) > - return 1; > + return 0; > > if (ret != -EPROBE_DEFER) > dev_warn(rcdu->dev, > "failed to initialize encoder %s (%d), skipping\n", > encoder->full_name, ret); > > - return 0; > + return ret; > } Perhaps just if (ret && ret != -EPROBE_DEFER) dev_warn(...); return ret; ? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds