From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4BF7C3ABC9 for ; Fri, 9 May 2025 19:29:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE21E10EACB; Fri, 9 May 2025 19:29:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="EHJ6L2g3"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 688D610EACC for ; Fri, 9 May 2025 19:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746818978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EeO2G/lhUp0fvXv3rAWysdL6gOIA9pKqHAwh5CmMO38=; b=EHJ6L2g3uJa0k4tM30FnRVYQ0ESRpWoMn94gTSq30SZFFrSzKKuWsxuudKKy5mKSNQXJjU 1KB1hIAWNtYdARIDEvHdldVBFF5QT+RSyVq73O1VZbR6ZJMHsXfJrnpUFP5bQpQD8WCVHa 1rzOCB6WAiLL8++5or48G5BOhm/zH7k= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-4aufopaXPIuuegv9iy6V1Q-1; Fri, 09 May 2025 15:29:35 -0400 X-MC-Unique: 4aufopaXPIuuegv9iy6V1Q-1 X-Mimecast-MFC-AGG-ID: 4aufopaXPIuuegv9iy6V1Q_1746818974 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-70a2cc313d4so44511447b3.0 for ; Fri, 09 May 2025 12:29:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746818974; x=1747423774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EeO2G/lhUp0fvXv3rAWysdL6gOIA9pKqHAwh5CmMO38=; b=NrY+cp3fm/JGBnCf7oAOtUj3bHQ3JOAZxlImC+AJgghJCAc9kCQmaniqcqEE7SdlAs qXDXRUa7nFF0qF4DbNMxxWv+n1HknkHn2HslFa866sX6c/7HzJzKV7RqeNq7v8xIgL4o 4eg6dG6CQcx0EZi6209E1scCMbVxRPmlVOPue/ua/1GMfoTioQdFlTMQrYbHDXFvbN2F 6vhz69UPKcQN2zzc3sLQ8fNBs8R6BwrUhbXuRrdM5pIRYaPR41935LqE1iSI4afs+5nF mBmRpLgftMuCUS0WZMrz7GsakHjbU61lbEUDXA2Ez7mwCYcOEgOLIB0NFGTojXjxEtXZ 96rw== X-Forwarded-Encrypted: i=1; AJvYcCUO28KguqEwDoCenRVUEW22sMGoLNXW+pnm6Yb5ot0OC4KKo/bCy62kEnASVTopli7kd2p06T9cjx0=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx/ApSN2BSdv0Syex7CyYu27LTkYXwM8vb5ji+TMpJr6DEMpnDl a580wjwHOqWvBhbh/fOGLNpF0x/GlUASNTrUTS4B/475vs0/WqflFaVUhS2P9itqkvJL07C2C8o E3KwItLmUSU9/syntrMRnjB54sf3pSAptIvZOXd27+zZpDl5rENQUINiEyWAl0M2vtinUajf3xR QSQH8B5LWHBDe2HL771LMLs/dRcPJLjsaYY58/q5jC X-Gm-Gg: ASbGncuEZiaRIJ89BO266o3jB4LpCyzn3unLkUfxOoi7Cvv4VLnwm4lh7R7zVcy1Xnh IKbIQbYrx5ZZ/vaUBP9N1LrPVUjj8A15YvBsqSFTV/2wt3r47wDUT7lslSwbhsbWpuHg= X-Received: by 2002:a05:6902:e92:b0:e73:71b:72f0 with SMTP id 3f1490d57ef6-e78fdc4e2fcmr6108675276.9.1746818974568; Fri, 09 May 2025 12:29:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+7fws5TA4mVh5ocXWRZzFUs/OIGtrMcL76jc2c3ct6B3jN6ukgxli2N8OqVa3oFfcQPsz93peY7PKT/AwuOs= X-Received: by 2002:a05:6902:e92:b0:e73:71b:72f0 with SMTP id 3f1490d57ef6-e78fdc4e2fcmr6108614276.9.1746818974149; Fri, 09 May 2025 12:29:34 -0700 (PDT) MIME-Version: 1.0 References: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> <20250509-drm-bridge-convert-to-alloc-api-v3-3-b8bc1f16d7aa@bootlin.com> In-Reply-To: <20250509-drm-bridge-convert-to-alloc-api-v3-3-b8bc1f16d7aa@bootlin.com> From: Anusha Srivatsa Date: Fri, 9 May 2025 14:26:14 -0400 X-Gm-Features: AX0GCFu24hR8J2U03NXjuAhnS6iurt_eMN47OaDzmkhI_jPjCeztvZ2zuh4Tk8Q Message-ID: Subject: Re: [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API To: Luca Ceresoli Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Douglas Anderson , Chun-Kuang Hu , Krzysztof Kozlowski , Paul Kocialkowski , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, "Rob Herring (Arm)" , Hsin-Te Yuan , Jani Nikula , Pin-yen Lin , Sui Jingfeng , Xin Ji X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mFqSGFr1IQBN6NMHzy55tAZwxn0lCcXxz6ZXt41FjrE_1746818974 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000071104f0634b8fc83" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --00000000000071104f0634b8fc83 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 9, 2025 at 9:56=E2=80=AFAM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > Looks good! Reviewed-by: Anusha Srivatsa > --- > > Cc: "Rob Herring (Arm)" > Cc: Hsin-Te Yuan > Cc: Jani Nikula > Cc: Pin-yen Lin > Cc: Sui Jingfeng > Cc: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > b/drivers/gpu/drm/bridge/analogix/anx7625.c > index > 8a9079c2ed5c22565d0733ef899119e347947d21..0ac4a82c5a6e5e665d913674b664905= a96c0d8e6 > 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2596,7 +2596,6 @@ static int anx7625_link_bridge(struct drm_dp_aux > *aux) > return ret; > } > > - platform->bridge.funcs =3D &anx7625_bridge_funcs; > platform->bridge.of_node =3D dev->of_node; > if (!anx7625_of_panel_on_aux_bus(dev)) > platform->bridge.ops |=3D DRM_BRIDGE_OP_EDID; > @@ -2630,10 +2629,10 @@ static int anx7625_i2c_probe(struct i2c_client > *client) > return -ENODEV; > } > > - platform =3D devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL); > - if (!platform) { > + platform =3D devm_drm_bridge_alloc(dev, struct anx7625_data, brid= ge, > &anx7625_bridge_funcs); > + if (IS_ERR(platform)) { > DRM_DEV_ERROR(dev, "fail to allocate driver data\n"); > - return -ENOMEM; > + return PTR_ERR(platform); > } > > pdata =3D &platform->pdata; > > -- > 2.49.0 > > --00000000000071104f0634b8fc83 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, May 9, = 2025 at 9:56=E2=80=AFAM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
This is the new API for allocating DRM= bridges.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Looks good!

Reviewed-by: Anu= sha Srivatsa <asrivats@redhat.com= >
=C2=A0
---

Cc: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Hsin-Te Yuan <yuanhsinte@chromium.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Pin-yen Lin <treapking@chromium.org>
Cc: Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: Xin Ji <xj= i@analogixsemi.com>
---
=C2=A0drivers/gpu/drm/bridge/analogix/anx7625.c | 7 +++----
=C2=A01 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/br= idge/analogix/anx7625.c
index 8a9079c2ed5c22565d0733ef899119e347947d21..0ac4a82c5a6e5e665d913674b66= 4905a96c0d8e6 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -2596,7 +2596,6 @@ static int anx7625_link_bridge(struct drm_dp_aux *aux= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ret;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

-=C2=A0 =C2=A0 =C2=A0 =C2=A0platform->bridge.funcs =3D &anx7625_brid= ge_funcs;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 platform->bridge.of_node =3D dev->of_node= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!anx7625_of_panel_on_aux_bus(dev))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 platform->bridge= .ops |=3D DRM_BRIDGE_OP_EDID;
@@ -2630,10 +2629,10 @@ static int anx7625_i2c_probe(struct i2c_client *cli= ent)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENODEV;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

-=C2=A0 =C2=A0 =C2=A0 =C2=A0platform =3D devm_kzalloc(dev, sizeof(*platform= ), GFP_KERNEL);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!platform) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0platform =3D devm_drm_bridge_alloc(dev, struct = anx7625_data, bridge, &anx7625_bridge_funcs);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (IS_ERR(platform)) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DRM_DEV_ERROR(dev, = "fail to allocate driver data\n");
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -ENOMEM;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return PTR_ERR(plat= form);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 pdata =3D &platform->pdata;

--
2.49.0

--00000000000071104f0634b8fc83--