From: David Herrmann <dh.herrmann@gmail.com>
To: Haixia Shi <hshi@chromium.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm: make unplugged flag specific to udl driver
Date: Wed, 10 Feb 2016 22:35:58 +0100 [thread overview]
Message-ID: <CANq1E4QPaVnRD5eutMdGujS5O4NhfrLunuq94LL5CVxD4zYWdg@mail.gmail.com> (raw)
In-Reply-To: <CALH7+Pj3DLZtN3JrLZbTzGNu-ohT7v=CQFp7ZjNOgovt7V+fzQ@mail.gmail.com>
Hi
On Wed, Feb 10, 2016 at 9:51 PM, Haixia Shi <hshi@chromium.org> wrote:
>> This should rather be:
>>
>> drm_release(inode, filp);
>> mutex_lock(&drm_global_mutex);
>> if (!dev->open_count && udl_device_is_unplugged(dev))
>> drm_put_dev(dev);
>> mutex_unlock(&drm_global_mutex);
>>
>> return 0;
>>
>> There is no reason to look at the return code of drm_release(), ever.
>
> But drm_release() does return a retcode. It would still make sense to return
> that as-is in case any existing code relies on it.
Nobody should ever return error codes from fops.release(). It is
completely bogus. You rather confuse generic user-space that calls
close(), than getting any benefit out of it.
But TBH, I don't care. Feel free to forward the return value. But
still, please change the order of the calls as I did.
Thanks
David
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-10 21:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 21:57 [PATCH 1/2] drm/msm: remove the drm_device_is_unplugged check Haixia Shi
2016-02-05 21:57 ` [PATCH 2/2] drm: make unplugged flag specific to udl driver Haixia Shi
2016-02-09 12:44 ` David Herrmann
2016-02-09 20:45 ` Haixia Shi
2016-02-09 20:52 ` David Herrmann
2016-02-10 23:16 ` [PATCH v2 2/2] drm: remove drm_device_is_unplugged checks in common drm code Haixia Shi
2016-02-09 10:25 ` [PATCH 1/2] drm/msm: remove the drm_device_is_unplugged check David Herrmann
2016-02-09 13:03 ` Daniel Vetter
2016-02-09 21:05 ` [PATCH 2/2] drm: make unplugged flag specific to udl driver Haixia Shi
2016-02-10 6:27 ` Daniel Vetter
2016-02-10 12:24 ` David Herrmann
2016-02-10 20:39 ` Haixia Shi
2016-02-10 21:38 ` David Herrmann
2016-02-10 21:46 ` Stéphane Marchesin
2016-02-10 21:54 ` David Herrmann
2016-02-10 22:02 ` Stéphane Marchesin
2016-02-10 22:09 ` David Herrmann
2016-02-11 8:17 ` Daniel Vetter
2016-02-10 20:51 ` Haixia Shi
2016-02-10 21:00 ` Haixia Shi
2016-02-10 21:33 ` David Herrmann
2016-02-10 21:35 ` David Herrmann [this message]
2016-02-10 21:38 ` Haixia Shi
2016-02-10 21:40 ` David Herrmann
2016-02-10 23:18 ` [PATCH v2 2/2] drm: remove drm_device_is_unplugged checks in common drm code Haixia Shi
2016-02-11 8:19 ` Daniel Vetter
2016-02-11 10:30 ` David Herrmann
2016-02-11 19:19 ` Haixia Shi
2016-02-11 21:57 ` [PATCH v3 2/2] drm: remove drm_device_is_unplugged and related code Haixia Shi
2016-02-12 6:22 ` Daniel Vetter
2016-02-12 19:50 ` Haixia Shi
2016-02-17 0:27 ` Haixia Shi
2016-02-26 14:29 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANq1E4QPaVnRD5eutMdGujS5O4NhfrLunuq94LL5CVxD4zYWdg@mail.gmail.com \
--to=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hshi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).