From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Herrmann Subject: Re: [PATCH 1/2] cirrus: add missing drm_connector_register call Date: Fri, 19 Sep 2014 10:37:03 +0200 Message-ID: References: <1411114297-13910-1-git-send-email-kraxel@redhat.com> <1411114297-13910-2-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com [209.85.223.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 268E489A34 for ; Fri, 19 Sep 2014 01:37:04 -0700 (PDT) Received: by mail-ie0-f175.google.com with SMTP id lx4so2928692iec.6 for ; Fri, 19 Sep 2014 01:37:03 -0700 (PDT) In-Reply-To: <1411114297-13910-2-git-send-email-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: Dave Airlie , open list , "open list:DRM DRIVERS" List-Id: dri-devel@lists.freedesktop.org Hi On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c > index e1c5c32..c7c5a9d 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_mode.c > +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c > @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev) > > drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); > > + drm_connector_register(connector); Error checking? And should probably include "Cc: # v3.15+". Thanks David > return connector; > } > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel