From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC215C4338F for ; Mon, 26 Jul 2021 15:11:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56C1960F4F for ; Mon, 26 Jul 2021 15:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 56C1960F4F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jlekstrand.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF9EE6FE97; Mon, 26 Jul 2021 15:11:21 +0000 (UTC) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BFA572D7F for ; Mon, 26 Jul 2021 15:11:21 +0000 (UTC) Received: by mail-yb1-xb2d.google.com with SMTP id a93so15421184ybi.1 for ; Mon, 26 Jul 2021 08:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BDfwKIgSKbxznyYPJRVzxNju+XZ1+lwgPHYGCuhA5pA=; b=jWiIPmZDg1jCBIqZv0cgAmanq2J7sUeaoqbGcMR5vKQ9saX/aLrhpYk4LLNhdxKFSh 8hrcEx1FxartIX7f5zlCUvfeVhZ7pz38POwhSusGeUM3WFJqfcE54PsNtpp0sX8PVnAl Q9DUdjCs+fVhqp95GIyLowoiocfD/VQw97nW4SpazC0c8YMCJoeZnGtMoRXEjg5HUnDQ fFYerCmN/7BRMoRvlj17ZA/pUjh5VwhW/8vgk9z9kmb/Au8Vby5dr8g+ElJfz/IRe191 OidW3mMXyf5cOWTTbToQUdT+hx3tURXwyZpFwH8XyvmP+dhG8KPXCJW9Lc+p9707DTL4 k8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BDfwKIgSKbxznyYPJRVzxNju+XZ1+lwgPHYGCuhA5pA=; b=V64DKXJWPY3fEPtt2F0nqOPzCd4XsOkW7syOFa/FRgFZ1BMOYIlnUKEaqYu1DX+qI/ bf0cxuqHe+cm0ShWbsKoUjNP5hLlHe9JoTjiakjBhEPkFBPjYeq0pCQ4lrX6VqikkYUb jdsfnXd+t4UvnKTB+S78eDXhcwXIe+fnnZrGMyLtJoJLvHS9wR6jUVBRk/gkzPFV3oZf iX8zoi2RmHXaDDdBOpwZkeFRUjwgTfUP3I9ATSlssnuCfuYIbckp+oH423fTJmaMGcv0 92jkrzkM/1HOGIWtgYj9I/KVQ7Jya1OeAHTSBgkg0MgDSXvm2TjmiMhWS80DHCmsP18/ Zg5A== X-Gm-Message-State: AOAM530tRHe3p+jvGcUzHImub3AolIunebVVxpAidyWfTntz//mOu5+e h9lD47lc4KrlvoijsoTiM6YmYAeUid9cgAjxrDeISg== X-Google-Smtp-Source: ABdhPJyATk0zkFzsgvDBrEHmWSwloqdqBBw6ZaZ4wfrikFlaRGMdXmqKXlk03IKz4SxHmYqXwGGgMiRHlztE0r7bip0= X-Received: by 2002:a25:d714:: with SMTP id o20mr10260386ybg.287.1627312280173; Mon, 26 Jul 2021 08:11:20 -0700 (PDT) MIME-Version: 1.0 References: <20210723172142.3273510-1-jason@jlekstrand.net> In-Reply-To: From: Jason Ekstrand Date: Mon, 26 Jul 2021 10:11:08 -0500 Message-ID: Subject: Re: [Intel-gfx] [PATCH 0/8] drm/i915: Migrate memory to SMEM when imported cross-device (v8) To: Matthew Auld Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jul 26, 2021 at 3:12 AM Matthew Auld wrote: > > On Fri, 23 Jul 2021 at 18:21, Jason Ekstrand wrote= : > > > > This patch series fixes an issue with discrete graphics on Intel where = we > > allowed dma-buf import while leaving the object in local memory. This > > breaks down pretty badly if the import happened on a different physical > > device. > > > > v7: > > - Drop "drm/i915/gem/ttm: Place new BOs in the requested region" > > - Add a new "drm/i915/gem: Call i915_gem_flush_free_objects() in i915_= gem_dumb_create()" > > - Misc. review feedback from Matthew Auld > > v8: > > - Misc. review feedback from Matthew Auld > > v9: > > - Replace the i915/ttm patch with two that are hopefully more correct > > > > Jason Ekstrand (6): > > drm/i915/gem: Check object_can_migrate from object_migrate > > drm/i915/gem: Refactor placement setup for i915_gem_object_create* > > (v2) > > drm/i915/gem: Call i915_gem_flush_free_objects() in > > i915_gem_dumb_create() > > drm/i915/gem: Unify user object creation (v3) > > drm/i915/gem/ttm: Only call __i915_gem_object_set_pages if needed > > drm/i915/gem: Always call obj->ops->migrate unless can_migrate fails > > > > Thomas Hellstr=C3=B6m (2): > > drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8) > > drm/i915/gem: Migrate to system at dma-buf attach time (v7) > > Should I push the series? Yes, please. Do we have a solid testing plan for things like this that touch discrete? I tested with mesa+glxgears on my DG1 but haven't run anything more stressful. --Jason > > > > drivers/gpu/drm/i915/gem/i915_gem_create.c | 177 ++++++++-------- > > drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 58 ++++-- > > drivers/gpu/drm/i915/gem/i915_gem_object.c | 20 +- > > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 + > > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 13 +- > > .../drm/i915/gem/selftests/i915_gem_dmabuf.c | 190 +++++++++++++++++- > > .../drm/i915/gem/selftests/i915_gem_migrate.c | 15 -- > > 7 files changed, 341 insertions(+), 136 deletions(-) > > > > -- > > 2.31.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx