dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: devel@driverdev.osuosl.org, Sascha Hauer <kernel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state
Date: Mon, 9 Jun 2014 15:47:46 -0300	[thread overview]
Message-ID: <CAOMZO5AMbM1W7AbHK0L5HoRdGgM12wChTAiGu27mGTruC1xQzQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5BvFR3uCJNkPF__r+1fY0PdVYX2581BjkoehGkhdFh7PQ@mail.gmail.com>

On Mon, Jun 9, 2014 at 3:38 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> I wonder if the problem is that HDMI and LVDS are interfering with each
>>> other wrt the required pixel clock, and LVDS is winning.  If we have
>>> HDMI enabled, many HDMI sinks will only work if we set one of their
>>> supported modes (with the dot clock within 1% - though some sinks are
>>> more lenient).
>>
>> Yes, it seems this is the case.
>
> I tested not using pll5 as the parent of LVDS:
>
> --- a/arch/arm/mach-imx/clk-imx6q.c
> +++ b/arch/arm/mach-imx/clk-imx6q.c
> @@ -439,12 +439,6 @@ static void __init imx6q_clocks_init(struct device_node *cc
>         clk_register_clkdev(clk[gpt_ipg_per], "per", "imx-gpt.0");
>         clk_register_clkdev(clk[enet_ref], "enet_ref", NULL);
>
> -       if ((imx_get_soc_revision() != IMX_CHIP_REVISION_1_0) ||
> -           cpu_is_imx6dl()) {
> -               clk_set_parent(clk[ldb_di0_sel], clk[pll5_video_div]);
> -               clk_set_parent(clk[ldb_di1_sel], clk[pll5_video_div]);
> -       }
> -
>         clk_set_parent(clk[ipu1_di0_pre_sel], clk[pll5_video_div]);
>         clk_set_parent(clk[ipu1_di1_pre_sel], clk[pll5_video_div]);
>         clk_set_parent(clk[ipu2_di0_pre_sel], clk[pll5_video_div]);
>
>
> Then the HDMI detection works fine and I get images on both HDMI and LVDS.
>
> I understand that many LVDS panels need a frequency range that can
> only be obtained via PLL5 though.

Also tested keeping LVDS parent as PLL5 and reverted this commit:

commit 17b9b3b9e88ac6564689283a08034faf2c048fdb
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Mon Apr 14 16:20:39 2014 +0200

    ARM: imx6q: clk: Parent DI clocks to video PLL via di_pre_sel

    Route the video PLL to the display interface clocks via the di_pre_sel
    and di_sel muxes by default.

    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: Shawn Guo <shawn.guo@freescale.com>


,then HDMI and LVDS work at the same time.

  reply	other threads:[~2014-06-09 18:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 13:56 [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state Russell King
2014-06-06 14:06 ` Greg Kroah-Hartman
2014-06-09 13:44 ` Fabio Estevam
2014-06-09 14:06   ` Russell King - ARM Linux
2014-06-09 14:29     ` Fabio Estevam
2014-06-09 14:33       ` Shawn Guo
2014-06-09 15:19         ` Fabio Estevam
2014-06-09 17:49       ` Russell King - ARM Linux
2014-06-09 18:15         ` Fabio Estevam
2014-06-09 18:38           ` Fabio Estevam
2014-06-09 18:47             ` Fabio Estevam [this message]
2014-06-09 20:09               ` Russell King - ARM Linux
2014-06-09 21:03                 ` Fabio Estevam
2014-06-10 12:58                 ` Fabio Estevam
2014-06-10 13:32                   ` Fabio Estevam
2014-06-11  8:17                     ` Russell King - ARM Linux
2014-06-11 15:34                       ` Philipp Zabel
2014-06-16 14:13                       ` Fabio Estevam
2014-06-16 21:49                         ` Russell King - ARM Linux
2014-06-10 15:13                   ` Russell King - ARM Linux
2014-06-10 16:14                     ` Russell King - ARM Linux
2014-06-10 17:04                       ` Russell King - ARM Linux
2014-06-10 17:36                         ` Fabio Estevam
2014-06-09 19:29             ` Russell King - ARM Linux
2014-06-09 19:29           ` Russell King - ARM Linux
2014-06-10 18:54       ` Tim Harvey
2014-06-10 19:03         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AMbM1W7AbHK0L5HoRdGgM12wChTAiGu27mGTruC1xQzQ@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux@arm.linux.org.uk \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).