From: Sean Paul <seanpaul@chromium.org>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm: Make sure drm_vblank_no_hw_counter isn't abused
Date: Mon, 8 Aug 2016 14:36:09 -0400 [thread overview]
Message-ID: <CAOw6vbLs4sUSoMYs225PiBeH3K86LsceCbMBguY2_ZdFzuLpmQ@mail.gmail.com> (raw)
In-Reply-To: <1470673661.5637.149.camel@intel.com>
On Mon, Aug 8, 2016 at 12:27 PM, Vivi, Rodrigo <rodrigo.vivi@intel.com> wrote:
> Reviewed-by: Rodrigo Vivi <rdorigo.vivi@intel.com>
>
> On Mon, 2016-08-08 at 18:24 +0200, Daniel Vetter wrote:
>> Shouldn't be possible since everyone kzallocs this, but better safe
>> than sorry. Random drive-by-idea really.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Applied to drm-misc
>> ---
>> drivers/gpu/drm/drm_irq.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
>> index f5a9f8cef360..10611a936059 100644
>> --- a/drivers/gpu/drm/drm_irq.c
>> +++ b/drivers/gpu/drm/drm_irq.c
>> @@ -1795,6 +1795,7 @@ EXPORT_SYMBOL(drm_crtc_handle_vblank);
>> */
>> u32 drm_vblank_no_hw_counter(struct drm_device *dev, unsigned int
>> pipe)
>> {
>> + WARN_ON_ONCE(dev->max_vblank_count != 0);
>> return 0;
>> }
>> EXPORT_SYMBOL(drm_vblank_no_hw_counter);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-08 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:24 [PATCH] drm: Make sure drm_vblank_no_hw_counter isn't abused Daniel Vetter
2016-08-08 16:27 ` Vivi, Rodrigo
2016-08-08 18:36 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOw6vbLs4sUSoMYs225PiBeH3K86LsceCbMBguY2_ZdFzuLpmQ@mail.gmail.com \
--to=seanpaul@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).