Re: [PATCH 1/7] drm/leases: Drop object_id validation for negative ids

[Dave Airlie <airlied@gmail.com>]

commit 2e1c9b2867656ff9a469d23e1dfe90cf77ec0c72
Author: Tejun Heo <tj@kernel.org>
Date:   Fri Mar 8 12:43:30 2013 -0800

    idr: remove WARN_ON_ONCE() on negative IDs

We used to WARN_ON if we hit a negative id, it appears we don't
anymore, so just update the commit msg to reflect that info on where
the code came from originally.

You had me wondering if I'd been dreaming up reasons for Keith to add code :-P

Dave.

On Thu, 14 Mar 2019 at 17:54, Boris Brezillon
<boris.brezillon@collabora.com> wrote:
>
> On Thu, 28 Feb 2019 15:49:04 +0100
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > Not exactly sure what's the aim here, but the canonical nil object has
> > id == 0, we don't use negative object ids for anything. Plus all
> > object_id are valided by the object_idr, there's nothing we need to do
> > on top of that ENOENT check a bit further down.
> >
> > Spotted while typing exhaustive igt coverage for all these
> > corner-cases.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> > ---
> >  drivers/gpu/drm/drm_lease.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
> > index 603b0bd9c5ce..1176d814cf7f 100644
> > --- a/drivers/gpu/drm/drm_lease.c
> > +++ b/drivers/gpu/drm/drm_lease.c
> > @@ -403,11 +403,6 @@ static int fill_object_idr(struct drm_device *dev,
> >       /* step one - get references to all the mode objects
> >          and check for validity. */
> >       for (o = 0; o < object_count; o++) {
> > -             if ((int) object_ids[o] < 0) {
> > -                     ret = -EINVAL;
> > -                     goto out_free_objects;
> > -             }
> > -
> >               objects[o] = drm_mode_object_find(dev, lessor_priv,
> >                                                 object_ids[o],
> >                                                 DRM_MODE_OBJECT_ANY);
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel