From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [git pull] drm fixes Date: Wed, 23 Apr 2014 07:54:17 +1000 Message-ID: References: <2619529.mEMJol0YfM@grover> <1549585.kmUPduLgev@grover> <10435496.M4aSBzoVye@grover> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by gabe.freedesktop.org (Postfix) with ESMTP id C98C86E10F for ; Tue, 22 Apr 2014 14:54:18 -0700 (PDT) Received: by mail-lb0-f170.google.com with SMTP id s7so75968lbd.15 for ; Tue, 22 Apr 2014 14:54:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Torvalds Cc: Ed Tomlinson , Linux Kernel Mailing List , DRI mailing list , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org On Wed, Apr 23, 2014 at 1:59 AM, Linus Torvalds wrote: > Dave, mind sending me a pull request for drm fixes? > > There's now at least these two: > > - "drm/radeon/aux: fix hpd assignment for aux bus" > - "drm/radeon: use fixed PPL ref divider if needed" > > that look like fairly fatal regressions when they affect somebody. > > The fact that we already had *two* independent bugs be reported within > days of that last out-of-merge-window pull request makes me very > unhappy with the state of drm pulls. > > So please make sure that future fixes really are *fixes*. For > regressions only. No more games like this. The pll fallout is fixes for the initial feature that was in the merge window, Tuning plls for monitors is always a pain in the ass, the previous algorithm took a couple of kernels a few years back to get where it was, unfortunately HDMI came along and showed up a bunch of its shortcomings. I'm happy Alex and Christian are on top of things in terms of tracking regressions and making sure they get fixed, the AUX fix yes I'm a bit pissed off about myself, but I missed a pull from a few weeks ago, felt guilty, and maybe should have chosen the other path and let it wait a merge, Christian just sent me a -fixes pull with all of these in it and I'll send it on to you in a few mins. Dave.