From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94411C83F1C for ; Wed, 30 Aug 2023 18:53:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E565010E179; Wed, 30 Aug 2023 18:53:43 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCEAD10E179; Wed, 30 Aug 2023 18:53:42 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52349d93c8aso1639693a12.1; Wed, 30 Aug 2023 11:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693421621; x=1694026421; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UiovL3shtkWUEkDqidG4l7jy83YUFtef6AXPkqmEUnM=; b=OqSA7pByQjwHH4e2+fnvWA/mnf+2dZAT2UDevUp/k6/YIMxBF8LF+hHhY3g8o2opEa +y2ZayewpcYVgMxWpTuTAIXClywe+5XB4+EDxVN5suFWLqnMNKswClHuooInavSAKAYz 823goUo1Goxvd1OStIy0T8zOHPhs+xXW0qUF8SCMovZh6f61Bu9oGqMxpZ3SpBkiSDNE bcgmzXhRZvPovIMVTK6XD94CpuqadXufQqABuG19LbN2IJrfU6u0JbqdAZo4HD9FGlMr FWFzNuJC+d+4u67s3HOIwCzxFqoXhHbRp0HDjuN5kYN1JGJDiQOAg5SY7l2Hda4OCecM lNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693421621; x=1694026421; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UiovL3shtkWUEkDqidG4l7jy83YUFtef6AXPkqmEUnM=; b=QgLUVdxlgxeNRjL4xg/KPUzckg+CycsosapdwwTYyXKg5YzcoE/oYrZtpOCRsDnZq8 YsJ/rg17/qZ3wqFzFGj3OneeN4onxugIgcKnaCVEy9xAHtWKN8oJin1maifNjpBUHHiE Wyo1A7cicZWu2Ich6wOPZ1xsxLAgQ+pg3UwNoB8RhFQux+C8o/55zQbXjStq73eekyUH L9GuLepeHq0pAkdHOFx4CUY6NZIcKfZpenv0FAfBra2AckwqxuXnlfw2D6eTI/b+RFoJ QTw0EGMAnOaA1QGngDCcOIkxz3xfWrRLwiEAVGqYbOzjshljfxCdzbD8YAoNGzprAX0k PuFQ== X-Gm-Message-State: AOJu0YyEt7OeEjueD21/cVE7DIw3eDmUmcrcR52+yg4pKFniekawlnhK EI/5IgGCm0jAXMUza/f3ZHkgzJjctK29yIhVlWg= X-Google-Smtp-Source: AGHT+IGy/AV2rmGPQ0TmC4v5zG95IX0+cAwadZku+J53oMPTpAKpv/G2XuYFL8RiHFA5uTbjfwFeSUROn8JL+r9+TG0= X-Received: by 2002:a05:6402:3554:b0:523:f69:9a0d with SMTP id f20-20020a056402355400b005230f699a0dmr2328724edd.4.1693421620864; Wed, 30 Aug 2023 11:53:40 -0700 (PDT) MIME-Version: 1.0 References: <20230724012419.2317649-1-sashal@kernel.org> <20230724012419.2317649-13-sashal@kernel.org> In-Reply-To: <20230724012419.2317649-13-sashal@kernel.org> From: Chia-I Wu Date: Wed, 30 Aug 2023 11:53:29 -0700 Message-ID: Subject: Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers To: Sasha Levin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Deucher , stable@vger.kernel.org, Lang Yu , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jul 23, 2023 at 6:24=E2=80=AFPM Sasha Levin wro= te: > > From: Lang Yu > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > When using cpu to update page tables, vm update fences are unused. > Install stub fence into these fence pointers instead of NULL > to avoid NULL dereference when calling dma_fence_wait() on them. > > Suggested-by: Christian K=C3=B6nig > Signed-off-by: Lang Yu > Reviewed-by: Christian K=C3=B6nig > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) We start getting this warning spew on chromeos, likely from dma_fence_is_later because the stub fence is on a different timeline: [ 273.334767] WARNING: CPU: 1 PID: 13383 at include/linux/dma-fence.h:478 amdgpu_sync_keep_later+0x95/0xbd [ 273.334769] Modules linked in: snd_seq_dummy snd_seq snd_seq_device bridge stp llc tun vhost_vsock vhost vhost_iotlb vmw_vsock_virtio_transport_common vsock 8021q veth lzo_rle lzo_compress zram uinput snd_acp_sof_mach snd_acp_mach snd_soc_dmic xt_cgroup rfcomm xt_MASQUERADE cmac algif_hash algif_skcipher af_alg btusb btrtl btintel btbcm rtw89_8852ae rtw89_pci rtw89_8852a rtw89_core snd_sof_amd_renoir snd_sof_xtensa_dsp snd_sof_amd_acp snd_acp_pci snd_acp_config snd_soc_acpi snd_pci_acp3x snd_sof_pci snd_sof snd_hda_codec_hdmi snd_sof_utils snd_hda_intel mac80211 snd_intel_dspcfg snd_hda_codec cros_ec_typec snd_hwdep roles snd_hda_core typec snd_soc_rt5682s snd_soc_rt1019 snd_soc_rl6231 ip6table_nat i2c_piix4 fuse bluetooth ecdh_generic ecc cfg80211 iio_trig_sysfs cros_ec_lid_angle cros_ec_sensors cros_ec_sensors_core industrialio_triggered_buffer kfifo_buf industrialio cros_ec_sensorhub r8153_ecm cdc_ether usbnet r8152 mii uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 [ 273.334795] videobuf2_common joydev [ 273.334799] CPU: 1 PID: 13383 Comm: chrome:cs0 Tainted: G W 5.10.192-23384-g3d3f0f0c5e4f #1 fe1e7e3b7510aa7b8e01701478119255f825a36f [ 273.334800] Hardware name: Google Dewatt/Dewatt, BIOS Google_Dewatt.14500.347.0 03/30/2023 [ 273.334802] RIP: 0010:amdgpu_sync_keep_later+0x95/0xbd [ 273.334804] Code: 00 00 b8 01 00 00 00 f0 0f c1 43 38 85 c0 74 26 8d 48 01 09 c1 78 24 49 89 1e 5b 41 5e 5d c3 cc cc cc cc e8 4a 94 ac ff eb ce <0f> 0b 49 8b 06 48 85 c0 75 af eb c2 be 02 00 00 00 48 8d 7b 38 e8 [ 273.334805] RSP: 0018:ffffb222c1817b50 EFLAGS: 00010293 [ 273.334807] RAX: ffffffff89bfc838 RBX: ffff8aa425e9ed00 RCX: 00000000000= 00000 [ 273.334808] RDX: ffff8aa426156a98 RSI: ffff8aa425e9ed00 RDI: ffff8aa4325= 18918 [ 273.334810] RBP: ffffb222c1817b60 R08: ffff8aa43ca6c0a0 R09: ffff8aa33af= 3c9a0 [ 273.334811] R10: fffffcf8c5986600 R11: ffffffff87a00fce R12: 00000000000= 00098 [ 273.334812] R13: 00000000005e2a00 R14: ffff8aa432518918 R15: 00000000000= 00000 [ 273.334814] FS: 00007e70f8694640(0000) GS:ffff8aa4e6080000(0000) knlGS:0000000000000000 [ 273.334816] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 273.334817] CR2: 00007e70ea049020 CR3: 0000000178e6e000 CR4: 00000000007= 50ee0 [ 273.334818] PKRU: 55555554 [ 273.334819] Call Trace: [ 273.334822] ? __warn+0xa3/0x131 [ 273.334824] ? amdgpu_sync_keep_later+0x95/0xbd [ 273.334826] ? report_bug+0x97/0xfa [ 273.334829] ? handle_bug+0x41/0x66 [ 273.334832] ? exc_invalid_op+0x1b/0x72 [ 273.334835] ? asm_exc_invalid_op+0x12/0x20 [ 273.334837] ? native_sched_clock+0x9a/0x9a [ 273.334840] ? amdgpu_sync_keep_later+0x95/0xbd [ 273.334843] amdgpu_sync_vm_fence+0x23/0x39 [ 273.334846] amdgpu_cs_ioctl+0x1782/0x1e56 [ 273.334851] ? amdgpu_cs_report_moved_bytes+0x5f/0x5f [ 273.334854] drm_ioctl_kernel+0xdf/0x150 [ 273.334858] drm_ioctl+0x1f5/0x3d2 [ 273.334928] ? amdgpu_cs_report_moved_bytes+0x5f/0x5f [ 273.334932] amdgpu_drm_ioctl+0x49/0x81 [ 273.334935] __x64_sys_ioctl+0x7d/0xc8 [ 273.334937] do_syscall_64+0x42/0x54 [ 273.334939] entry_SYSCALL_64_after_hwframe+0x4a/0xaf [ 273.334941] RIP: 0033:0x7e70ff797649 [ 273.334943] Code: 04 25 28 00 00 00 48 89 45 c8 31 c0 48 8d 45 10 c7 45 b0 10 00 00 00 48 89 45 b8 48 8d 45 d0 48 89 45 c0 b8 10 00 00 00 0f 05 <41> 89 c0 3d 00 f0 ff ff 77 1d 48 8b 45 c8 64 48 2b 04 25 28 00 00 [ 273.334945] RSP: 002b:00007e70f8693170 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 273.334947] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007e70ff7= 97649 [ 273.334948] RDX: 00007e70f8693248 RSI: 00000000c0186444 RDI: 00000000000= 00013 [ 273.334950] RBP: 00007e70f86931c0 R08: 00007e70f8693350 R09: 00007e70f86= 93340 [ 273.334951] R10: 000000000000000a R11: 0000000000000246 R12: 00000000c01= 86444 [ 273.334952] R13: 00007e70f8693380 R14: 00007e70f8693248 R15: 00000000000= 00013 [ 273.334954] ---[ end trace fc066a0fcea39e8c ]---