From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [BUG/REGRESSION] Kernel 4.5-rc1 on Acube Sam460ex AMCC 460ex Power PC motherboards Date: Mon, 25 Jan 2016 11:20:21 -0800 Message-ID: References: <55592246.5090505@candw.ms> <555A25D7.7070000@candw.ms> <56815C0F.4010207@candw.ms> <56A173FA.2090405@candw.ms> <56A1E59B.5060200@vodafone.de> <56A6190D.3090609@candw.ms> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113e7958c697e8052a2d756c Return-path: Received: from mail-yk0-f171.google.com (mail-yk0-f171.google.com [209.85.160.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53E066E15A for ; Mon, 25 Jan 2016 11:20:22 -0800 (PST) Received: by mail-yk0-f171.google.com with SMTP id u68so44184191ykd.2 for ; Mon, 25 Jan 2016 11:20:22 -0800 (PST) In-Reply-To: <56A6190D.3090609@candw.ms> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julian Margetson Cc: Dave Hansen , Maling list - DRI developers , aperez@alexperez.com, chzigotzky@xenosoft.de List-Id: dri-devel@lists.freedesktop.org --001a113e7958c697e8052a2d756c Content-Type: text/plain; charset=UTF-8 On Mon, Jan 25, 2016 at 4:46 AM, Julian Margetson wrote: > Oops starting Xorg with kernel 4.5-rc1 on Acube Sam460ex amcc460ex powerpc > motherboard. > > ====================================================================================================================== > 01c8f1c44b83a0825b573e7c723b033cece37b86 is the first bad commit > commit 01c8f1c44b83a0825b573e7c723b033cece37b86 > Author: Dan Williams > Date: Fri Jan 15 16:56:40 2016 -0800 > > mm, dax, gpu: convert vm_insert_mixed to pfn_t > > Convert the raw unsigned long 'pfn' argument to pfn_t for the purpose of > evaluating the PFN_MAP and PFN_DEV flags. When both are set it triggers > _PAGE_DEVMAP to be set in the resulting pte. > > There are no functional changes to the gpu drivers as a result of this > conversion. > > Signed-off-by: Dan Williams > Cc: Dave Hansen > Cc: David Airlie > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > > :040000 040000 dc71b6dc188dea4b6ce95f5fd1e4e73cc3663cbe > 8a745459a14cd2a6f4e1c71fda3e54333d023f43 M arch > :040000 040000 9e8103b65698f677e17becdac53914ca029a6197 > f656e15bffef4ea8c848176a79eb50a071ec323e M drivers > :040000 040000 3ffc222d7e0f1067772798d08777aeb54136026e > e2b423f85aaaf0cb25d48d1e15771fc5bddf7981 M fs > :040000 040000 392d2dea8185ba8f0d1c101782831ceed9aa9812 > 9e3001b04052daa1b3204b6f2a6e26138a4ed7dd M include > :040000 040000 f81d8cfe3052b7259b75a58656a65efdaad40284 > 969d0ff262020f27a695172ce89ae5f6088e8d44 M mm > Hmm, this commit could only cause a behavior change if it modifies the value of the pfn as seen by insert_pfn(). Can you try the attached debug patch to see if that assumption is being violated? --001a113e7958c697e8052a2d756c Content-Type: text/x-patch; charset=US-ASCII; name="pfn-debug.patch" Content-Disposition: attachment; filename="pfn-debug.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ijucz88e0 ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvcGZuX3QuaCBiL2luY2x1ZGUvbGludXgvcGZuX3Qu aAppbmRleCAzNzQ0OGFiNWZiNWMuLjgxODEzMDUxY2VjNyAxMDA2NDQKLS0tIGEvaW5jbHVkZS9s aW51eC9wZm5fdC5oCisrKyBiL2luY2x1ZGUvbGludXgvcGZuX3QuaApAQCAtMTYsMTAgKzE2LDI1 IEBACiAjZGVmaW5lIFBGTl9ERVYgKDFVTCA8PCAoQklUU19QRVJfTE9ORyAtIDMpKQogI2RlZmlu ZSBQRk5fTUFQICgxVUwgPDwgKEJJVFNfUEVSX0xPTkcgLSA0KSkKIAorZXh0ZXJuIHBmbl90IHBo eXNfdG9fcGZuX3QocGh5c19hZGRyX3QgYWRkciwgdW5zaWduZWQgbG9uZyBmbGFncyk7CisKK3N0 YXRpYyBpbmxpbmUgYm9vbCBwZm5fdF9oYXNfcGFnZShwZm5fdCBwZm4pCit7CisJcmV0dXJuIChw Zm4udmFsICYgUEZOX01BUCkgPT0gUEZOX01BUCB8fCAocGZuLnZhbCAmIFBGTl9ERVYpID09IDA7 Cit9CisKK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBwZm5fdF90b19wZm4ocGZuX3QgcGZu KQoreworCXJldHVybiBwZm4udmFsICYgflBGTl9GTEFHU19NQVNLOworfQorCiBzdGF0aWMgaW5s aW5lIHBmbl90IF9fcGZuX3RvX3Bmbl90KHVuc2lnbmVkIGxvbmcgcGZuLCB1bnNpZ25lZCBsb25n IGZsYWdzKQogewogCXBmbl90IHBmbl90ID0geyAudmFsID0gcGZuIHwgKGZsYWdzICYgUEZOX0ZM QUdTX01BU0spLCB9OwogCisJV0FSTl9PTkNFKHBmbl90X3RvX3BmbihwZm5fdCkgIT0gcGZuLCAi cGZuOiAlI2x4IHBmbl90OiAlI2x4XG4iLAorCQkJcGZuLCBwZm5fdF90b19wZm4ocGZuX3QpKTsK KwogCXJldHVybiBwZm5fdDsKIH0KIApAQCAtMjksMTggKzQ0LDYgQEAgc3RhdGljIGlubGluZSBw Zm5fdCBwZm5fdG9fcGZuX3QodW5zaWduZWQgbG9uZyBwZm4pCiAJcmV0dXJuIF9fcGZuX3RvX3Bm bl90KHBmbiwgMCk7CiB9CiAKLWV4dGVybiBwZm5fdCBwaHlzX3RvX3Bmbl90KHBoeXNfYWRkcl90 IGFkZHIsIHVuc2lnbmVkIGxvbmcgZmxhZ3MpOwotCi1zdGF0aWMgaW5saW5lIGJvb2wgcGZuX3Rf aGFzX3BhZ2UocGZuX3QgcGZuKQotewotCXJldHVybiAocGZuLnZhbCAmIFBGTl9NQVApID09IFBG Tl9NQVAgfHwgKHBmbi52YWwgJiBQRk5fREVWKSA9PSAwOwotfQotCi1zdGF0aWMgaW5saW5lIHVu c2lnbmVkIGxvbmcgcGZuX3RfdG9fcGZuKHBmbl90IHBmbikKLXsKLQlyZXR1cm4gcGZuLnZhbCAm IH5QRk5fRkxBR1NfTUFTSzsKLX0KLQogc3RhdGljIGlubGluZSBzdHJ1Y3QgcGFnZSAqcGZuX3Rf dG9fcGFnZShwZm5fdCBwZm4pCiB7CiAJaWYgKHBmbl90X2hhc19wYWdlKHBmbikpCg== --001a113e7958c697e8052a2d756c Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --001a113e7958c697e8052a2d756c--