From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCAD7C10F16 for ; Mon, 6 May 2024 09:18:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14DC410EEC5; Mon, 6 May 2024 09:18:34 +0000 (UTC) X-Greylist: delayed 412 seconds by postgrey-1.36 at gabe; Mon, 06 May 2024 09:18:32 UTC Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7439910EEC5 for ; Mon, 6 May 2024 09:18:32 +0000 (UTC) Received: from localhost (unknown [IPv6:2a02:810b:4340:6430:4685:ff:fe12:5967]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 782101B1; Mon, 6 May 2024 11:11:36 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 06 May 2024 11:11:36 +0200 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , , From: "Michael Walle" To: "AngeloGioacchino Del Regno" , Subject: Re: [PATCH v2 3/3] drm/mediatek: Implement OF graphs support for display paths X-Mailer: aerc 0.16.0 References: <20240409120211.321153-1-angelogioacchino.delregno@collabora.com> <20240409120211.321153-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20240409120211.321153-4-angelogioacchino.delregno@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Angelo, On Tue Apr 9, 2024 at 2:02 PM CEST, AngeloGioacchino Del Regno wrote: > +static int mtk_drm_of_get_ddp_ep_cid(struct device_node *node, > + int output_port, enum mtk_drm_crtc_path crtc_path, Not sure what's your base branch is, but "enum mtk_drm_crtc_path" was renamed to "enum mtk_crtc_path" in commit 9e149879038f5 ('drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"'). > +/** > + * mtk_drm_of_ddp_path_build_one - Build a Display HW Pipeline for a CRT= C Path > + * @dev: The mediatek-drm device > + * @cpath: CRTC Path relative to a VDO or MMSYS > + * @out_path: Pointer to an array that will contain the new pipeline > + * @out_path_len: Number of entries in the pipeline array > + * > + * MediaTek SoCs can use different DDP hardware pipelines (or paths) dep= ending > + * on the board-specific desired display configuration; this function wa= lks > + * through all of the output endpoints starting from a VDO or MMSYS hard= ware > + * instance and builds the right pipeline as specified in device trees. > + * > + * Return: > + * * %0 - Display HW Pipeline successfully built and validated > + * * %-ENOENT - Display pipeline was not specified in device tree > + * * %-EINVAL - Display pipeline built but validation failed > + * * %-ENOMEM - Failure to allocate pipeline array to pass to the caller > + */ > +static int mtk_drm_of_ddp_path_build_one(struct device *dev, enum mtk_dr= m_crtc_path cpath, likewise > + const unsigned int **out_path, > + unsigned int *out_path_len) -michael