From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2248CC5321D for ; Mon, 26 Aug 2024 20:02:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 889B110E1F6; Mon, 26 Aug 2024 20:02:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=cknow.org header.i=@cknow.org header.b="yMt3jDjC"; dkim-atps=neutral X-Greylist: delayed 342 seconds by postgrey-1.36 at gabe; Mon, 26 Aug 2024 20:02:32 UTC Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F54110E29E for ; Mon, 26 Aug 2024 20:02:32 +0000 (UTC) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1724702208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lSNB16YmTmGtSszFku9OEpzxCSlM3sSnGKMEEle5Jqc=; b=yMt3jDjCx/B0z6xC082cVw0HQY4Me/FagDvE50oGlZZXCMF5Jq6LNhf+2Qxm6GxDSPpGhy osQCkmyACysyLu+u650VEqjzcGGEzFWl7uD9cGiG2uKMLG+neaKZVbHPdqs4NgFfV9kN36 F6RecMyRzzHf5tUuKzWLlXy6Zq2aaUrO4Nqz767HIHttvZPw1xfRvEvz1/LRgm5SKRKgW5 e98Q7S61cpPqJ69fgCnm4wfemUXqHoZmqLDjo7EW4Gn5fu5LKSLz7FsFpc5L1IqLMoKSNw zVNkFcO6HzXLN8irNUWL94mMo90EcrTYmktZgOLYwgwJL0BRUy5LS22/0nNbVQ== Content-Type: multipart/signed; boundary=128cfb0fa1f91e2aae272ffecd950e1f386b558b6f3d91eca48fb6bdbb70; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Mon, 26 Aug 2024 21:56:34 +0200 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Detlev Casanova" , "Chukun Pan" References: <23624422.6Emhk5qWAg@trenzalore> <20240825140824.200453-1-amadeus@jmu.edu.cn> <22403959.EfDdHjke4D@bootstrap> In-Reply-To: <22403959.EfDdHjke4D@bootstrap> X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --128cfb0fa1f91e2aae272ffecd950e1f386b558b6f3d91eca48fb6bdbb70 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Aug 26, 2024 at 8:28 PM CEST, Detlev Casanova wrote: > On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote: > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > > > ... > > > + opp-1416000000 { > > > + opp-hz =3D /bits/ 64 <1416000000>; > > > + opp-microvolt =3D <725000 725000 950000>; > > > + opp-microvolt-L1 =3D <712500 712500 950000>; > > > + opp-microvolt-L2 =3D <700000 700000 950000>; > > > + opp-microvolt-L3 =3D <700000 700000 950000>; > > > + opp-microvolt-L4 =3D <700000 700000 950000>; > > > + opp-microvolt-L5 =3D <700000 700000 950000>; > > > + clock-latency-ns =3D <40000>; > > > + }; > > > ... > >=20 > > I'm curious if these frequencies work properly. On the bsp kernel, > > 'opp-microvolt-L' is used by the PVTM driver, I don't know > > if it works on the upstream kernel. > > Which seems to correspond to the set opp-hz value. As mentionned by Alexe= y,=20 > the opp-microvolt-L.* values are not used by the driver. > > I also have not tested any cpufreq settings/driver on this board yet. I c= an=20 > remove the opp-microvolt-L.* for now. If you run this command on the upstream kernel: ``grep -r "opp-microvolt" arch/arm64/boot/dts/rockchip/`` you'll see it doesn't use the opp-microvolt-LN variants anywhere, so this is indeed a downstream/BSP only thing. --128cfb0fa1f91e2aae272ffecd950e1f386b558b6f3d91eca48fb6bdbb70 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZszd+QAKCRDXblvOeH7b bsPMAP9CORw/HV6VNrTduOL78GjAIEpWxM/M9+0BOgYkBHnzpQEAjK8fuZpW3HrN ri8LuinsuvlO+D0OMT9SEJJAE8prZQE= =pQv4 -----END PGP SIGNATURE----- --128cfb0fa1f91e2aae272ffecd950e1f386b558b6f3d91eca48fb6bdbb70--