From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7D54C5B552 for ; Wed, 4 Jun 2025 07:18:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EF8310E055; Wed, 4 Jun 2025 07:18:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="iih1QpkM"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FBB510E055; Wed, 4 Jun 2025 07:18:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3AF2E6111F; Wed, 4 Jun 2025 07:18:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45CBEC4CEE7; Wed, 4 Jun 2025 07:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749021517; bh=hLV6bUQrXlzvrssls30vFCh548KG3Got5mJHkOfBrZE=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=iih1QpkMfxbsDlUAHq58TXJMsIkC8tbUwjHy5IpvIlgaDruw6V4+kZYqxpdwqRNmL wnioY11fpwZFS0uK2W3iDN5MPTCtXv5J3lhhQhiOHtBa/4sEIvhx/1Wq2839gC15mY lNkmheiTD+OKRABEajAtfk6eOI8Laah/kcz+TyfdRcEzJLAAxHUmst5/GByU+fyaCz OBUJ4SbJzt4jsODMvDWQ1suuwzf/wwe4Y9ETvYr9MKALlOzC8SVnAoU/JqHxCI+GnN i7A7+Df57sFynFYl8jaLjTCys7U8x0ePCnWqd9YpofNnY1giZSljV/FR1X99UggmSN GrxxPW8M5B6tQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Jun 2025 09:18:31 +0200 Message-Id: Cc: "John Hubbard" , "Ben Skeggs" , "Joel Fernandes" , "Timur Tabi" , "Alistair Popple" , , , , Subject: Re: [PATCH v4 04/20] rust: add new `num` module with useful integer operations From: "Benno Lossin" To: "Alexandre Courbot" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , "David Airlie" , "Simona Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" X-Mailer: aerc 0.20.1 References: <20250521-nova-frts-v4-0-05dfd4f39479@nvidia.com> <20250521-nova-frts-v4-4-05dfd4f39479@nvidia.com> In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed Jun 4, 2025 at 2:05 AM CEST, Alexandre Courbot wrote: > On Wed Jun 4, 2025 at 8:02 AM JST, Benno Lossin wrote: >> On Mon Jun 2, 2025 at 3:09 PM CEST, Alexandre Courbot wrote: >>> On Thu May 29, 2025 at 4:27 PM JST, Benno Lossin wrote: >>>> On Thu May 29, 2025 at 3:18 AM CEST, Alexandre Courbot wrote: >>>>> On Thu May 29, 2025 at 5:17 AM JST, Benno Lossin wrote: >>>>>> On Wed May 21, 2025 at 8:44 AM CEST, Alexandre Courbot wrote: >>>>>>> + /// Align `self` up to `alignment`. >>>>>>> + /// >>>>>>> + /// `alignment` must be a power of 2 for accurate results. >>>>>>> + /// >>>>>>> + /// Wraps around to `0` if the requested alignment pushes the = result above the type's limits. >>>>>>> + /// >>>>>>> + /// # Examples >>>>>>> + /// >>>>>>> + /// ``` >>>>>>> + /// use kernel::num::NumExt; >>>>>>> + /// >>>>>>> + /// assert_eq!(0x4fffu32.align_up(0x1000), 0x5000); >>>>>>> + /// assert_eq!(0x4000u32.align_up(0x1000), 0x4000); >>>>>>> + /// assert_eq!(0x0u32.align_up(0x1000), 0x0); >>>>>>> + /// assert_eq!(0xffffu16.align_up(0x100), 0x0); >>>>>>> + /// assert_eq!(0x4fffu32.align_up(0x0), 0x0); >>>>>>> + /// ``` >>>>>>> + fn align_up(self, alignment: Self) -> Self; >>>>>> >>>>>> Isn't this `next_multiple_of` [1] (it also allows non power of 2 >>>>>> inputs). >>>>>> >>>>>> [1]: https://doc.rust-lang.org/std/primitive.u32.html#method.next_mu= ltiple_of >>>>> >>>>> It is, however the fact that `next_multiple_of` works with non powers= of >>>>> two also means it needs to perform a modulo operation. That operation >>>>> might well be optimized away by the compiler, but ACAICT we have no w= ay >>>>> of proving it will always be the case, hence the always-optimal >>>>> implementation here. >>>> >>>> When you use a power of 2 constant, then I'm very sure that it will ge= t >>>> optimized [1]. Even with non-powers of 2, you don't get a division [2]= . >>>> If you find some code that is not optimized, then sure add a custom >>>> function. >>>> >>>> [1]: https://godbolt.org/z/57M9e36T3 >>>> [2]: https://godbolt.org/z/9P4P8zExh >>> >>> That's impressive and would definitely work well with a constant. But >>> when the value is not known at compile-time, the division does occur >>> unfortunately: https://godbolt.org/z/WK1bPMeEx >>> >>> So I think we will still need a kernel-optimized version of these >>> alignment functions. >> >> Hmm what exactly is the use-case for a variable align amount? Could you >> store it in const generics? > > Say you have an IOMMU with support for different pages sizes, the size > of a particular page can be decided at runtime. > >> >> If not, there are also these two variants that are more efficient: >> >> * option: https://godbolt.org/z/ecnb19zaM >> * unsafe: https://godbolt.org/z/EqTaGov71 >> >> So if the compiler can infer it from context it still optimizes it :) > > I think the `Option` (and subsequent `unwrap`) is something we want to > avoid on such a common operation. Makes sense. >> But yeah to be extra sure, you need your version. By the way, what >> happens if `align` is not a power of 2 in your version? > > It will just return `(self + (self - 1)) & (alignment - 1)`, which will > likely be a value you don't want. So wouldn't it be better to make users validate that they gave a power-of-2 alignment? > So yes, for this particular operation we would prefer to only use powers > of 2 as inputs - if we can ensure that then it solves most of our > problems (can use `next_multiple_of`, no `Option`, etc). > > Maybe we can introduce a new integer type that, similarly to `NonZero`, > guarantees that the value it stores is a power of 2? Users with const > values (90+% of uses) won't see any difference, and if working with a > runtime-generated value we will want to validate it anyway... I like this idea. But it will mean that we have to have a custom function that is either standalone and const or in an extension trait :( But for this one we can use the name `align_up` :) Here is a cool idea for the implementation: https://godbolt.org/z/x6navM5WK > (I can already hear you saying "send that to upstream Rust!" ^_^;) This one isn't as clear I'd say. The stdlib of Rust is strict on what gets added. Since they already have `next_multiple_of`, adding a `prev_multiple_of` sounds very reasonable, but a new type for powers of 2? That could be something they don't want to add. Ultimately I don't know, but if we need it, we should build it ourselves first :) --- Cheers, Benno