From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EF8CC83F25 for ; Mon, 21 Jul 2025 15:33:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAF0B10E56D; Mon, 21 Jul 2025 15:33:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FKLmbz+C"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E6D510E56D for ; Mon, 21 Jul 2025 15:33:56 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 88D0D5C5E03; Mon, 21 Jul 2025 15:33:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 596E8C4CEED; Mon, 21 Jul 2025 15:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753112035; bh=hyyuyfbxHodKvSyqExb7ImrgCIZwTFL9rTdX6poyFrA=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=FKLmbz+CxSiNML7F+p65oJIHLjvl95Pv/hVEblsYZTTWlg6gn+oXGNJIX02LFyhNp dCdS718g72JP2jUZgODe+lsRafSHI8B1NVsB/c+RkJhy78hxeiwLkUZMb41Uksd/jQ 5q6ZrH7iMt0d1l+wQzZBq9JoyE5TqH6cru4LgW2R2OZLRSzM95tonuefJNuY3N/ElU aCT0x45l7ucQzuuFb/++Py7R21I6ckm84W/+wl3v5oHefDsQ1a8hErT1TL7nXd8c0b 1yH54Yn0rmRQ4fZGAyBU03ZovYUIPFViunpxP8ao3gwRYPJFwj24Z7eBR1asyjActb +fjS6Sh+P5zoA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 21 Jul 2025 17:33:50 +0200 Message-Id: Subject: Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments Cc: , , , , , , , , , , , , , To: "Beata Michalska" From: "Danilo Krummrich" References: <20250626162313.2755584-1-beata.michalska@arm.com> In-Reply-To: <20250626162313.2755584-1-beata.michalska@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote: > With the Opaque, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constraints. By using Opaque, > ioctl handlers are forced to use unsafe code where none is actually > needed. This adds needless complexity and maintenance overhead, > brining no safety benefits. > Drop the use of Opaque for ioctl arguments as that is not the best > fit here. > > Signed-off-by: Beata Michalska > Acked-by: Danilo Krummrich > Reviewed-by: Boqun Feng The patch does not apply on top of drm-misc-next and does not have a base revision. Can you please let me know which commit this patch applies on top of or res= end? - Danilo