dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Doug Anderson" <dianders@chromium.org>
Cc: <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
	<linus.walleij@linaro.org>, <neil.armstrong@linaro.org>,
	<jessica.zhang@oss.qualcomm.com>, <sam@ravnborg.org>,
	<skhan@linuxfoundation.org>,
	<linux-kernel-mentees@lists.linux.dev>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] drm: Add MIPI read_multi func and two write macros
Date: Wed, 30 Jul 2025 18:49:42 -0600	[thread overview]
Message-ID: <DBPTT2WUK2CH.1V1KX11EJPIFB@brighamcampbell.com> (raw)
In-Reply-To: <CAD=FV=WpbU-iuEDVRuMm87H48PKQ3pz5aBwTRyedguFQA3dvTQ@mail.gmail.com>

On Wed Jul 30, 2025 at 9:56 AM MDT, Doug Anderson wrote:
>> +/**
>> + * mipi_dsi_dcs_write_var_seq_multi - transmit a DCS command with non-static
>> + * payload
>
> I should have been explicit, but the above "non-static" should also be
> "non-constant". ;-)
>
> I could probably fix that when applying, or you could send a v4. Up to you.

Oops. This obviously needed to change as well, but I tunnel-visioned
hard. I'll go ahead and fix it in v4.

Naturally, I wouldn't be at all opposed to you or any other maintainer
making such a small change to one of my patches as it heads upstream,
but I'd rather not ask you to remember to make that change after a long
vacation and a busy merge window. There's no need for me to add even a
little more cognitive load to your job than what's necessary.

> Speaking of applying this, I'll be on vacation next week, so I won't
> be able to apply the patches until the week after. That will also give
> anyone else on the list a chance to comment if they want...

Awesome! I'll plan to sit tight and act on whatever feedback I get on
v4.

If you happen to be flying over northern Utah to get to your
destination, look out the window. I'll wave as you go by.

Cheers,
Brigham

  reply	other threads:[~2025-07-31  0:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  6:17 [PATCH v3 0/3] drm/panel: novatek-nt35560: Fix bug and clean up Brigham Campbell
2025-07-30  6:17 ` [PATCH v3 1/3] drm/panel: novatek-nt35560: Fix invalid return value Brigham Campbell
2025-08-18  9:24   ` Linus Walleij
2025-07-30  6:17 ` [PATCH v3 2/3] drm: Add MIPI read_multi func and two write macros Brigham Campbell
2025-07-30 15:56   ` Doug Anderson
2025-07-31  0:49     ` Brigham Campbell [this message]
2025-07-30  6:17 ` [PATCH v3 3/3] drm/panel: novatek-nt35560: Clean up driver Brigham Campbell
2025-08-18  9:25   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBPTT2WUK2CH.1V1KX11EJPIFB@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=airlied@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=sam@ravnborg.org \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).