From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93138C87FCB for ; Sat, 9 Aug 2025 12:43:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5E0010E1CD; Sat, 9 Aug 2025 12:43:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="u11pErsp"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46C6410E1A6; Sat, 9 Aug 2025 12:43:36 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 59488601EC; Sat, 9 Aug 2025 12:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7CB9C4CEE7; Sat, 9 Aug 2025 12:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754743414; bh=cgfbLlDM+uE3+w25kWktwTIc62T2IyuW6cl8fggU7PE=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=u11pErsp7VIq26LXHPPbXqrMnoGd+QIkhewgVPIlifdznkGsntXAcA4zu5/TXjDOL nSoP5O07QFLyQ4rl5OnTCu45GtAaYxOiP43sHntMZx3ZlI53g6wWOHMFWOLYjKGcnL cChTFQMFPIpJT6RtlZd8dbu7fhpnNGMo3rXjQ7FNqx3ex92YPcfOh67aOVn8Dvn6BX uqW2ZNPunsAnbhvpZAmpNJqF5W8L3zZ/Gxdtf6AI0OjFwB25J7G6SPHlsNxEuxUdd3 jJi5MB8zl6GvvqFmiCvfzGY14AB32WJ17s+jDWR8/G5xh6rr3TScDWNq/RsbODR8Pm yML4kNE5XJHDQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 09 Aug 2025 14:43:30 +0200 Message-Id: Subject: Re: [PATCH v6 01/26] drm/gpuvm: Pass map arguments through a struct Cc: , "Matthew Brost" , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , "Boris Brezillon" , "Brendan King" , "Boris Brezillon" , "Caterina Shablia" , "Rob Clark" , To: "Himal Prasad Ghimiray" From: "Danilo Krummrich" References: <20250807164338.1832254-1-himal.prasad.ghimiray@intel.com> <20250807164338.1832254-2-himal.prasad.ghimiray@intel.com> In-Reply-To: <20250807164338.1832254-2-himal.prasad.ghimiray@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Aug 7, 2025 at 6:43 PM CEST, Himal Prasad Ghimiray wrote: > From: Boris Brezillon > > We are about to pass more arguments to drm_gpuvm_sm_map[_ops_create](), > so, before we do that, let's pass arguments through a struct instead > of changing each call site every time a new optional argument is added. > > v5 > - Use drm_gpuva_op_map=E2=80=94same as drm_gpuvm_map_req > - Rebase changes for drm_gpuvm_sm_map_exec_lock() > - Fix kernel-docs > > v6 > - Use drm_gpuvm_map_req (Danilo/Matt) > > Cc: Danilo Krummrich > Cc: Brendan King > Cc: Boris Brezillon > Cc: Caterina Shablia > Cc: Rob Clark > Cc: Matthew Brost > Cc: > Signed-off-by: Boris Brezillon > Signed-off-by: Caterina Shablia Caterina does not seem to be involved in handling this patch. Either you sh= ould remove this SoB or adda Co-developed-by: tag for her if that's the case. > Signed-off-by: Himal Prasad Ghimiray You may also want to add a Co-developed-by: tag for yourself given that you= made significant changes to the patch. But that's between Boris and you of cours= e. > +/** > + * struct drm_gpuvm_map_req - arguments passed to drm_gpuvm_sm_map[_ops_= create]() > + */ > +struct drm_gpuvm_map_req { > + /** > + * @op_map: struct drm_gpuva_op_map > + */ > + struct drm_gpuva_op_map op_map; I think this should just be 'op', the outer structure says 'map' already. > +};