From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1F6FCA0EC4 for ; Tue, 12 Aug 2025 20:36:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1464E10E63F; Tue, 12 Aug 2025 20:36:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cc8mOwnQ"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 711AF10E63F for ; Tue, 12 Aug 2025 20:35:59 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8F4EE5C56BC; Tue, 12 Aug 2025 20:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2625AC4CEF0; Tue, 12 Aug 2025 20:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755030958; bh=+StpLUbIz4Cn8lrRgBX1tOfusvqJ9s3Ec800QrIyjPA=; h=Date:Cc:To:From:Subject:References:In-Reply-To:From; b=cc8mOwnQMZouqZAXTEyb1qgwlK4LxASLn1WbYrTamO5NeyoXsjkgs45NM5Ncb6WeX lfrGeYSoJyYaUu/mwqNs4aR/NSPzwj/E20p6IlE4JbfJNUgnneyAPDcBuctVUNO/Ci zBjbIwiEwiuAnUOPIfRZ4Bmrk/Ay921LRP8MnzaYyx9tmeg/gqA7fMzyVWQICn+6D1 L8HGJLEpqgdHcDZIUrsq+IidnYyDtSaa2AEd5sNgWED626W6EsGp6f62fb1l8IDodX H9awiY1T72RF14BTyzbL1DxAJBwy3wM1jGHCRtUxIitVHNvFxKZkDLkJ4lB9W4sVmB 3kgHgKcu0V+aw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Aug 2025 22:35:52 +0200 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , , To: "Miguel Ojeda" From: "Danilo Krummrich" Subject: Re: [PATCH 1/4] rust: alloc: replace aligned_size() with Kmalloc::aligned_layout() References: <20250731154919.4132-1-dakr@kernel.org> <20250731154919.4132-2-dakr@kernel.org> In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue Aug 12, 2025 at 10:12 PM CEST, Miguel Ojeda wrote: > On Tue, Aug 12, 2025 at 10:00=E2=80=AFPM Danilo Krummrich wrote: >> >> I don't think so, it just lead to pad to the alignment for Vmalloc too. >> >> Technically, this makes no difference, since Vmalloc is always PAGE_SIZE= aligned >> and the size always a multiple of PAGE_SIZE. > > Got it, thanks for the quick reply! Then I guess we could have skipped > the Fixes in this one, but it is not a big deal and as usual it > depends on how one defines "fix". Yeah, in the past I was more on the "'Fixes:' for actual bugs only" side of things, but I changed my mind a bit; I find it useful to have this as a reference even for minor issues that might not be actual bugs, such as this one.