From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05F8CCA0FF2 for ; Wed, 3 Sep 2025 08:27:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 780CE10E4C5; Wed, 3 Sep 2025 08:27:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GGTyGxhX"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D82A010E4C5; Wed, 3 Sep 2025 08:27:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A774043DFC; Wed, 3 Sep 2025 08:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FCF1C4CEF0; Wed, 3 Sep 2025 08:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756888069; bh=RB95aOX+kayC1qRy+/KzYs7xMyQLdRtju6GyR1JJy4c=; h=Date:To:From:Subject:Cc:References:In-Reply-To:From; b=GGTyGxhXDPj/D/mL/FktKW2Jhl6+O+srYKvLL2UpeNyBlC/2u5YUY6Xcw2fBujEkw djeD3MthykhOOjLgMXTk2on5Tvs4Clbj8mXVtFbDE5Vx9It70FI/kaP0bGrPqvEQ/b w8VU/q9XxXYjn3LuQiugbvIvBpZT47OEEoe3kOCC/LkVq5mlpYNn9/w9WqlaI2E+5G HJu8ZOQ07xw8IrpW+hnTRrChSbA5nWZ4T1E0Vv7MzA17uav1faItGrtQL+e19yB7WN fw1EJ2OygYlfoHT+I3kF3SpcJHrjFSsjjhrfJR++PWU1kt7EdVA0PkIW93dO/GE0GC yDOKvPV6wcM6Q== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Sep 2025 10:27:43 +0200 Message-Id: To: "Alexandre Courbot" From: "Danilo Krummrich" Subject: Re: [PATCH v3 02/11] gpu: nova-core: move GSP boot code out of `Gpu` constructor Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "David Airlie" , "Simona Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "John Hubbard" , "Alistair Popple" , "Joel Fernandes" , "Timur Tabi" , , , , References: <20250902-nova_firmware-v3-0-56854d9c5398@nvidia.com> <20250902-nova_firmware-v3-2-56854d9c5398@nvidia.com> <843554b1-f4c5-43f5-a23b-583339708bea@kernel.org> In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed Sep 3, 2025 at 9:10 AM CEST, Alexandre Courbot wrote: > On Wed Sep 3, 2025 at 8:12 AM JST, Danilo Krummrich wrote: >> On 9/2/25 4:31 PM, Alexandre Courbot wrote: >>> pub(crate) fn new( >>> pdev: &pci::Device, >>> devres_bar: Arc>, >> >> The diff is hiding it, but with this patch we should also make sure that= this=20 >> returns impl PinInit rather than Result. >> >> I think this should be possible now. > > There is still code that can return errors (falcon creation, etc) - do > you mean that we should move it into the pin initializer and turn it > into a `try_pin_init`? Yeah, that would be better practice, if it doesn't work out for a good reas= on we can also fall back to Result, but we should at least try to avoid it.