From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 790E6CA1010 for ; Wed, 3 Sep 2025 21:27:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1D1010E93F; Wed, 3 Sep 2025 21:27:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="KIm/iPg6"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E30610E93F; Wed, 3 Sep 2025 21:27:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 55C6C44731; Wed, 3 Sep 2025 21:27:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 544CDC4CEE7; Wed, 3 Sep 2025 21:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756934861; bh=LDEavBgpdf6sYM/MgH8ENkdlyZyknViZWzX3GHBJMuc=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=KIm/iPg6kx16gIafv7f0CtiOtExR8gU89IBmCE0vnx0Xvs0u3xOEPCjGOrdE6+ahW 3lR/UkRwtu8eEAFVhXHvWkOFeHGw1hWmRJ1oNr6bkdyIgX9avxrPIbaKp2lw1hs+6e 1tY4zESTXlnp78HD0gJmNPgwua6kuwREysr0H98J5/DWOpsof2Rjoyu9kfXgVPZ0y1 rUI3sZkmeC0EUFvHxqpU9zj4QCgLQmYRFjKqDE3soOJe7C+N2x5eDxkn5cC4SBs3Fh 0dt1yvFaIY3jN493HvP8hhxJJqhCHgYvZ7UkzmsSTVzcBUdzxC0e9pajfv7tXdKUkV SQLF1h/RVIcuw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Sep 2025 23:27:37 +0200 Message-Id: Subject: Re: [PATCH v2] Revert "drm/nouveau: Remove waitque for sched teardown" Cc: "Lyude Paul" , "David Airlie" , "Simona Vetter" , "Sumit Semwal" , =?utf-8?q?Christian_K=C3=B6nig?= , , , To: "Philipp Stanner" From: "Danilo Krummrich" References: <20250901083107.10206-2-phasta@kernel.org> In-Reply-To: <20250901083107.10206-2-phasta@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon Sep 1, 2025 at 10:31 AM CEST, Philipp Stanner wrote: > This reverts: > > commit bead88002227 ("drm/nouveau: Remove waitque for sched teardown") > commit 5f46f5c7af8c ("drm/nouveau: Add new callback for scheduler teardow= n") > > from the drm/sched teardown leak fix series: > > https://lore.kernel.org/dri-devel/20250710125412.128476-2-phasta@kernel.o= rg/ > > The aforementioned series removed a blocking waitqueue from > nouveau_sched_fini(). It was mistakenly assumed that this waitqueue only > prevents jobs from leaking, which the series fixed. > > The waitqueue, however, also guarantees that all VM_BIND related jobs > are finished in order, cleaning up mappings in the GPU's MMU. These jobs > must be executed sequentially. Without the waitqueue, this is no longer > guaranteed, because entity and scheduler teardown can race with each > other. > > Revert all patches related to the waitqueue removal. > > Fixes: bead88002227 ("drm/nouveau: Remove waitque for sched teardown") > Suggested-by: Danilo Krummrich > Signed-off-by: Philipp Stanner Applied to drm-misc-fixes, thanks!