From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16CDAD29C33 for ; Mon, 19 Jan 2026 15:50:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56A2210E4A6; Mon, 19 Jan 2026 15:50:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Otq9VxZx"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCDE910E4AE; Mon, 19 Jan 2026 15:50:15 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1D28042D65; Mon, 19 Jan 2026 15:50:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ADE4C19423; Mon, 19 Jan 2026 15:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768837815; bh=4bjc5aajcuzBHvXCPRPtvjsISc8dexTvQe1HeiR9z9k=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=Otq9VxZxTCDWO7NP/o5dZBtU+J9r7kwGjWWaBS5ZuQFvXYQW6QmPZYzv6lLEZSEh7 eIf8etXkH7aluEctAwBnFQfwWBGmNCS8EYcpQzSyDpaHdYfzFmM5MAa6rYQL1pr67F vA23Z9df91ftloLSZ85httOC3PIqxdUsZT2T3ETaEd8GZkLQaSS/6hPMGn5teV0hjN NE0tOqrwZK84qi+OCVdWaScwcK/9jHBVoGnvrpXbYxC0h9bKJzJbnzoRzhK6TLuTzt /jPktw9xMgoQVbVtx6ada4eBunVBCMMj7TeBfjmxbDJPYBfT7e/wUDTdUk0aYLTWpG MnDLlyeo5vHPw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 16:50:10 +0100 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v2 07/10] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded Cc: "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "John Hubbard" , "Alistair Popple" , "Joel Fernandes" , "Timur Tabi" , "Edwin Peer" , "Eliot Courtney" , , , , , "Lyude Paul" To: "Alexandre Courbot" References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue Dec 16, 2025 at 5:27 AM CET, Alexandre Courbot wrote: > /// Loads the FWSEC firmware into `falcon` and execute it. > - pub(crate) fn run( > - &self, > - dev: &Device, > - falcon: &Falcon, > - bar: &Bar0, Hm..the method also takes a &pci::Bar, so its either called from a bound co= ntext or within a Revocable critical section. Leaving the other argument as &Device makes it obvious which one it = is (and should be). > - ) -> Result<()> { > + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon, bar: &B= ar0) -> Result<()> { > // Reset falcon, load the firmware, and run it. > falcon > .reset(bar) > > --=20 > 2.52.0