From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B577E67A9C for ; Tue, 3 Mar 2026 08:53:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7043F10E12F; Tue, 3 Mar 2026 08:53:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="WRRhIhW7"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC4A710E12F for ; Tue, 3 Mar 2026 08:53:03 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0C6914E424F4; Tue, 3 Mar 2026 08:53:02 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CF6105FF29; Tue, 3 Mar 2026 08:53:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B877610368535; Tue, 3 Mar 2026 09:52:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772527980; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=dHzjooMLjEqCTLZkR7Emb0dRbrH9mQHksD/dLPxL7GM=; b=WRRhIhW7vgeQlUBtRYy3lSHT0g7ssIR9CeRQtfoaN7OdZZdWE5SukFGsLLbCIdZ9Rvk5P5 x3YGBf1y7LiWXgLFbXOctHmnCPnz6MEz3JcxtoJgT292PBQcgsZgMb67LDJ4ygTtonXGHl NptOg5QWRQocFJ+rT7Ew6sQ0KYNhopPIv/Sav8VfDWGHMf3N+Fwfq3dDYHpRN0lgFNsuS4 Ag/RcE50VgDX70ljiGOuXWmZFxz47/OxtST229tGXoP+k/sbo+ZIeYJPL0S9DBPiU1pXDO 7lRXVgu2hOg0vCWsWnhBaS9gdwTuafASl358/MHiepvPTdxf4JFQsgDLCDOXbQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Mar 2026 09:52:49 +0100 Message-Id: Cc: "Heikki Krogerus" , "Greg Kroah-Hartman" , "Dmitry Baryshkov" , "Peter Chen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Vinod Koul" , "Kishon Vijay Abraham I" , "Heiko Stuebner" , "Sandy Huang" , "Andy Yan" , "Yubing Zhang" , "Frank Wang" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Amit Sunil Dhamne" , "Dragan Simic" , "Johan Jonker" , "Diederik de Haas" , "Peter Robinson" , , , , , , , To: "Chaoyi Chen" From: "Luca Ceresoli" Subject: Re: [PATCH v14 7/9] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection X-Mailer: aerc 0.20.1 References: <20260119073100.143-1-kernel@airkyi.com> <20260119073100.143-8-kernel@airkyi.com> <601a8b51-7411-429d-91a1-0633cabce9ee@rock-chips.com> In-Reply-To: <601a8b51-7411-429d-91a1-0633cabce9ee@rock-chips.com> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Chaoyi, On Tue Mar 3, 2026 at 1:44 AM CET, Chaoyi Chen wrote: >>> +static int cdn_dp_parse_next_bridge_dt(struct cdn_dp_device *dp) >>> +{ >>> + struct device_node *np =3D dp->dev->of_node; >>> + struct device_node *port __free(device_node) =3D of_graph_get_port_by= _id(np, 1); >>> + struct drm_bridge *bridge; >>> + int count =3D 0; >>> + int ret =3D 0; >>> + int i; >>> + >>> + /* If device use extcon, do not use hpd bridge */ >>> + for (i =3D 0; i < dp->ports; i++) { >>> + if (dp->port[i]->extcon) { >>> + dp->bridge_count =3D 1; >>> + return 0; >>> + } >>> + } >>> + >>> + /* One endpoint may correspond to one next bridge. */ >>> + for_each_of_graph_port_endpoint(port, dp_ep) { >>> + struct device_node *next_bridge_node __free(device_node) =3D >>> + of_graph_get_remote_port_parent(dp_ep); >>> + >>> + bridge =3D of_drm_find_bridge(next_bridge_node); >>> + if (!bridge) { >>> + ret =3D -EPROBE_DEFER; >>> + goto out; >>> + } >>> + >>> + drm_bridge_get(bridge); >>> + dp->next_bridge_valid =3D true; >>> + dp->next_bridge_list[count] =3D bridge; >> >> Correct, but the drm_bridge_get() slightly far away from the assignement= is >> a bit misleading. I hadn't seen it initially so I suspected a missing ge= t. >> >> I suggest to do it in a single statement, for clarity: >> >> dp->next_bridge_list[count] =3D bridgedrm_bridge_get(bridge); >> > > I think the bridgedrm_bridge_get here seems to be a typo? Oops, of course! :) As you probably guessed, I was meaning: dp->next_bridge_list[count] =3D drm_bridge_get(bridge); > Anyway, thank you very much for your efforts on the bridge lifetime. > I will fix this in the next version :) Thanks! Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com