From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB2A1FCA198 for ; Mon, 9 Mar 2026 22:01:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4302F10E5C6; Mon, 9 Mar 2026 22:01:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RvI5JFp1"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0680510E5C6; Mon, 9 Mar 2026 22:01:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6779D600B0; Mon, 9 Mar 2026 22:01:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53789C4CEF7; Mon, 9 Mar 2026 22:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773093710; bh=aHvp/ydDvwJNhlqaovNKYyy8F9mwenGS+ySHQYofdzU=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=RvI5JFp17G6ngaZ1JKSX0k6cw+FhIcpfRhJVFCPCWuIsAyLXCg2qApKWf6zyOlcp5 lnQKIfFWuw7E9kjpU8QDj+RNvYR/1scHUesCsHd7mMwBR5/fPl5HCzgSO42WhDMHnE eQOdaIwdpvZrNRxIfrcwR8a9b9viqE6/Wm4fKPxo+2xG7oq7O2I/Zj43Xoh9YzOB2H eH98HCgXAr2xT48334A7+jDfNmep+IKjz9FJN/4ATcymS6nqd/Pl5i+T5P8V3j2T60 RdYpsQLChc3LwHqKaYTbJjIjbE1psl/swPoKPXOL6xDo3E50ZPUMmUjTVl58birVKs 2jNNtb+UUAMeQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 09 Mar 2026 23:01:46 +0100 Message-Id: Subject: Re: [PATCH 6/9] gpu: nova-core: generalize `flush_into_kvec` to `flush_into_vec` Cc: "Alice Ryhl" , "Alexandre Courbot" , "David Airlie" , "Simona Vetter" , , , , To: "Eliot Courtney" From: "Danilo Krummrich" References: <20260227-rmcontrol-v1-0-86648e4869f9@nvidia.com> <20260227-rmcontrol-v1-6-86648e4869f9@nvidia.com> <093ca23e-7081-42db-a202-0a42c51741a3@kernel.org> In-Reply-To: <093ca23e-7081-42db-a202-0a42c51741a3@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon Mar 9, 2026 at 10:57 PM CET, Danilo Krummrich wrote: > On 2/27/2026 1:32 PM, Eliot Courtney wrote: >> Add general `flush_into_vec` function. Add `flush_into_kvvec` >> convenience wrapper alongside the existing `flush_into_kvec` function. >> This is generally useful but immediately used for e.g. holding RM >> control payloads, which can be large (~>=3D20 KiB). > > Why not just always use KVVec? It also seems that the KVec variant is not= used? (Besides its single usage in GspSequence, which wouldn't hurt to be a KVVec= .) > If there's no reason for having both, I'd also just call this into_vec().