From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E51CCCC6B1B for ; Thu, 2 Apr 2026 07:47:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4790C10EFA2; Thu, 2 Apr 2026 07:47:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="EEw2+Eoh"; dkim-atps=neutral Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00ED810EFA2 for ; Thu, 2 Apr 2026 07:47:04 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id B1E1F1A30E6; Thu, 2 Apr 2026 07:47:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E717C5FDEB; Thu, 2 Apr 2026 07:47:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 893CB10450FD5; Thu, 2 Apr 2026 09:46:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775116020; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jP1S9CLoFCyCnLNLDQLchVG1x47qmcvo35n8094xxtc=; b=EEw2+EohuHWiQDl0euKZWW9UvzVB0BjVykwNv503S8nlKVpQN8iO41I6vgPKyBo5EaqANG dHxRujC0ptwCSuEY5mrJQ/YBd6blGZ7OPFKtVvN38VrXhi0ghaz/PxMkf4AjGGe3mLy9HO vGRHIT8mjoWC6BXHAu/YOpNA04JoHlv8rUzDXBx8KXQIcZhct7MD9aTTkvlzpIUS8Qa/6A uWMqp5ocQhYgvE3QXhkSTFk3eKQz98zTgdqLS6OGU3hoNohhNuWD1QL6Kg2lMpSa9O9vYv GKDTTAg+/Z2byYELg/JAPNn72lkY1568inHalpeAh2QtKr9jq2NvacA7fe7NeA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Apr 2026 09:46:46 +0200 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field Cc: "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , , , "Adam Ford" , "Alexander Stein" , "Christopher Obbard" , "Daniel Scally" , "Emanuele Ghidoli" , "Fabio Estevam" , "Francesco Dolcini" , "Frieder Schrempf" , "Gilles Talis" , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , "Heiko Schocher" , "Josua Mayer" , "Kieran Bingham" , "Marco Felsch" , "Martyn Welch" , "Oleksij Rempel" , "Peng Fan" , "Richard Hu" , "Shengjiu Wang" , "Stefan Eichenberger" , "Vitor Soares" To: "Damon Ding" , "Marek Vasut" , "Stefan Agner" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Liu Ying" , "Rob Herring" , "Saravana Kannan" X-Mailer: aerc 0.20.1 References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-5-c7f2af536a24@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Damon, On Tue Mar 31, 2026 at 9:21 AM CEST, Damon Ding wrote: > On 3/31/2026 3:25 AM, Luca Ceresoli wrote: >> The meaning of this flag may not be obvious at first sight. >> >> Reviewed-by: Liu Ying >> Tested-by: Martyn Welch >> Tested-by: Alexander Stein # TQMa8MPxL= /MBa8MPxL >> Signed-off-by: Luca Ceresoli Thanks for looking at this series! >> @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops { >> struct dw_hdmi_plat_data { >> struct regmap *regm; >> >> + /* >> + * The HDMI output port number must be 1 if the port is described >> + * in the device tree. 0 if the device tree does not describe the >> + * next component (legacy mode, i.e. without >> + * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge). >> + */ >> unsigned int output_port; >> >> unsigned long input_bus_encoding; >> > > Tested-by: Damon Ding (on rk3399) Uhm, I'm not sure what can be tested in a patch only adding a comment. Did you mean 'Reviewed-by' maybe? Also, I _think_ the best syntax for a comment would be using a '#', not parentheses, so that would be | Tested-by: Damon Ding # on rk3399 This is the recommended syntax for the 'Cc: stable' lines [0], at least. Additionally b4 keeps comments with the '#' as those in [1], while is discards the ones in parentheses. [0] https://docs.kernel.org/process/stable-kernel-rules.html [1] https://lore.kernel.org/all/2948177.mvXUDI8C0e@steina-w/ Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com