From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 232BCCCFA13 for ; Thu, 30 Apr 2026 11:01:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8220F10E13A; Thu, 30 Apr 2026 11:01:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="e6y3ybpx"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9A0D10E13A for ; Thu, 30 Apr 2026 11:01:29 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id CBD224E42B77; Thu, 30 Apr 2026 11:01:27 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9CCD960495; Thu, 30 Apr 2026 11:01:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0CDC0102F1848; Thu, 30 Apr 2026 13:01:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777546886; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BhwMpVtUqkZLZTp2J+UylAJhGh2ZmpvGBNpjDJzUMOE=; b=e6y3ybpx6XSBy89HNTym3ef67O679iDtfDSaVQki6qQgpE5PVC7smn8l7fAmVxRIeU69nm KFxQ7O7x/2AAX9vGZ1hH/Pk4DNc4TD49bVWA+foXLOOkZbcqppmZvPD6aFcVnoqtEExu4z dLVieyAAzlEdiqoySGYVzMK8lkHwP4btby+Z4H9hk6PEg+6TPCsNKEc3TehuEBHXdso+pU V7Z41toV/9v6pxnKb7XQjLX4AIHsEuJQIad0KqavjZM6HmTK3vFwHSRsFn+hvNDF7d16hn BA7fFfvvwuhW7aFYLvkxGwgmMvg24sjUvjKda0gwqiqcIiM3zf1qqkSrxYhdgg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Apr 2026 13:01:16 +0200 Message-Id: Subject: Re: [PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe To: "Osama Abdelkader" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260423200604.324615-1-osama.abdelkader@gmail.com> In-Reply-To: <20260423200604.324615-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Osama, On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop drm_bridge_remove() in chipone_dsi_probe. Wait, this patch must drop drm_bridge_remove() in chipone_dsi_remove() too! Otherwise it'd be introducing an excess put, and consequent use-after-free. I have to withdraw my R-by. You can amend in v4. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com