From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D34E0CD3427 for ; Tue, 5 May 2026 14:05:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38A1310E9C1; Tue, 5 May 2026 14:05:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="T6dtH4l3"; dkim-atps=neutral Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6991F10E9C1 for ; Tue, 5 May 2026 14:05:50 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id DB6B1C5D739; Tue, 5 May 2026 14:06:34 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id F0D186053C; Tue, 5 May 2026 14:05:47 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 81E7D11AD01FF; Tue, 5 May 2026 16:05:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777989946; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=LiFhYTTWhPaYG7k6xQeGXacfbvfc085+WmffoobFaWY=; b=T6dtH4l3SQK8LakHyVwGl4F+Oc2UPGOw7DGU4SoB5JYhBmRNfbFaZbGwbMM8BVGf/cTSdJ TPs3f6k4Da6l+T2I7apfGrj8TAUNblc/HSE2nt4W2tCn5mZockxFpnIKvI+U/GhW4uflal p49Mwskl/NbrSvWh3ixnlOKcur52nwrXfjrso3lE6c7ZPjkR2GEJ/b50VGHZ0k0I5kHzz+ NHCByjlmqwBVUGT4izIkL/1TYeGeEAEulBemXbys2xuEl4EnA9684gfH6Q5XI6W6dbqat2 GawapjmBH1FYkduLf87eZDe5VdNf7gP607oQSn5RjGB7JB5GhNYnTdk2eamS+A== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 May 2026 16:05:36 +0200 Message-Id: Subject: Re: [PATCH v4 10/11] drm: zynqmp_dp: switch to of_drm_get_bridge_by_endpoint() Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Clark" , "Dmitry Baryshkov" , "Abhinav Kumar" , "Jessica Zhang" , "Sean Paul" , "Marijn Suijten" , "Sumit Semwal" , "John Stultz" , "Tomi Valkeinen" , "Michal Simek" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , , To: "Laurent Pinchart" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com> <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-10-b578c3daaf10@bootlin.com> <20260504152418.GC1455860@killaraus.ideasonboard.com> In-Reply-To: <20260504152418.GC1455860@killaraus.ideasonboard.com> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Mon May 4, 2026 at 5:24 PM CEST, Laurent Pinchart wrote: [...] >> @@ -2461,10 +2459,15 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) >> * Acquire the next bridge in the chain. Ignore errors caused by port@= 5 >> * not being connected for backward-compatibility with older DTs. >> */ >> - ret =3D drm_of_find_panel_or_bridge(dp->dev->of_node, 5, 0, NULL, >> - &dp->next_bridge); >> - if (ret < 0 && ret !=3D -ENODEV) >> - goto err_reset; >> + dp->bridge.next_bridge =3D of_drm_get_bridge_by_endpoint(dp->dev->of_n= ode, 5, 0); >> + if (IS_ERR(dp->bridge.next_bridge)) { >> + if (PTR_ERR(dp->bridge.next_bridge) =3D=3D -ENODEV) { >> + dp->bridge.next_bridge =3D NULL; >> + } else { >> + ret =3D PTR_ERR(dp->bridge.next_bridge); >> + goto err_reset; >> + } > > I would find > > if (PTR_ERR(dp->bridge.next_bridge) !=3D -ENODEV) { > ret =3D PTR_ERR(dp->bridge.next_bridge); > goto err_reset; > } > > dp->bridge.next_bridge =3D NULL; > > easier to read. Up to you. Makes sense, change queued up for v5. Thanks for reviewing! Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com