From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4772ACD4F4A for ; Mon, 18 May 2026 16:57:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0AB410E5E3; Mon, 18 May 2026 16:57:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="br9gs2ij"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 198EF10E5E3; Mon, 18 May 2026 16:57:43 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A9ECE4E42CE4; Mon, 18 May 2026 16:57:41 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 624815FFA3; Mon, 18 May 2026 16:57:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5E86511AF8B49; Mon, 18 May 2026 18:57:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779123459; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=+GUakJQgQQZFR4eLPRoEYE8uJGTNPLGY7yG6NqQt4F0=; b=br9gs2ijS56RroxBZhqIXRTDxRxrOt1E+VTi6oIGgEftGswlZl6ckZ8/bk1KhGsH6d5AIx WCl2r0QWQR1G8PyPsLIuMSEwum4loYYz2Yt7PgSKLea4v87HO8mb9a83Zvb+pDp3CgCp8Y rzRULoohRN7ioF9ATxpXUTDxbmwTO795rq7Pke2mXsCg4F2hRggnj2O6obtI2xtKh0SfgK SOO2QR36NKTPybZWsgL3YNn+S0dz1eRiyHi6U21UQkjrwAGh+m2k18tYi9extz+qrqglLU snTrBIIl3ZGHmuoF8QrK4DSR3nZCa0Wkeg0uakCMZFEIuBVtexvrt2Ftz17YxA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 18 May 2026 18:57:26 +0200 Message-Id: Subject: Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data Cc: "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "David Airlie" , "Simona Vetter" , "Jagan Teki" , "Liu Ying" , "Adrien Grassein" , "Peter Senna Tschudin" , "Ian Ray" , "Martyn Welch" , "Russell King" , "Douglas Anderson" , "Dmitry Baryshkov" , "Biju Das" , "Tommaso Merciai" , "Manikandan Muralidharan" , "Andy Yan" , "Xin Ji" , "Loic Poulain" , "Fei Shao" , "Arnd Bergmann" , "Kees Cook" , , , To: =?utf-8?b?VXdlIEtsZWluZS1Lw7ZuaWcgKFRoZSBDYXBhYmxlIEh1Yik=?= , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lyude Paul" , "Danilo Krummrich" , "Marcus Folkesson" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260518100401.631351-2-u.kleine-koenig@baylibre.com> In-Reply-To: <20260518100401.631351-2-u.kleine-koenig@baylibre.com> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon May 18, 2026 at 12:04 PM CEST, Uwe Kleine-K=C3=B6nig (The Capable Hu= b) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > The mentioned robustness is relevant for a planned change to struct > i2c_device_id that replaces .driver_data by an anonymous union. > > While touching all these arrays, unify usage of whitespace in the list > terminator and drop trailing commas there. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com