From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11D42CD4F54 for ; Thu, 28 May 2026 13:23:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67A9010F17D; Thu, 28 May 2026 13:23:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="qzw+ZxBI"; dkim-atps=neutral Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010047.outbound.protection.outlook.com [52.101.56.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 700C010F17D for ; Thu, 28 May 2026 13:23:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZX33xOv71pPRWVqJpb8W+Rlz4+NPJqvD2NO3hi/0YAhp+Cuc6NhEhPPurvqjl6738qMnetfqqC9flLzVUlkOYrkmeHiXx//IR07txLb183dsHcJW1wcXwVvIkejYy1VWO0/1m0YfkphifKDiphLvfyKJ+SdL1NhmOF8WdYHp224MVqiYYdSuZ/thTDUH1UpPHgwZW2Ynp3xUN8ioR4FkjUASW8rLo72gsgAEV5sMgfrOVaIFqSddr9RPKycHeMhgtDgB2+Ej2Q4ogJHruWewSGNyq8lEbZUMZ7SuuUq+YopV7tHY+aiy1IJIWu26qcF1a+R7hvi3mUTmKKoPa5LMYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0ie+dUaCvHoiDKRbEvFEDb6NhZCvls/PQKq4MFbduk=; b=IPLBtCZPVrdOK0tYGkGx1NPTv5BoqqoYTJHZAoOaUEdp82cLt2mOUTlqrOry93dmjJDZaqQsAjmLecfRioMlRkzv5YTqGxudRTHcjaDD0rQfDOjvAg85yDQCVgKK3oPmr6nXWA/qd7P9iu6XZDGyaver9CMPHRLHExVI50Kz9soHioX5j3br1jdF2dWkrqBHPO2mGsPRRjGgz1g411DvXpEXwuVdriJ0zMaHyY0fHuptHJtA0uCkgww//wKnI9RCSbjbmqz6C95GwEHtTh9YGCz5/nC4BvlGP5yEQueLdXAVXRCEwvdjZsSr+rm8Gh9GdkLairjS13QTfc+odCHXGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0ie+dUaCvHoiDKRbEvFEDb6NhZCvls/PQKq4MFbduk=; b=qzw+ZxBImts2yUtTUGGUfX2+Y7oQyBWqKoVQ8Dzk2NZAkqCIJJ6KCya2IjvqURSXpKClM4s8N4nfpoI9+NP/RajTKRcm4iaGTF4/R62eWvoAeUSdt+9D/A2zNDvxLD0HUUGRt4aCNa7QfTVfDeqvV5k1fUoq2oBEiDfRHA6ams+OEuDF6WvuZ+eOH2kTqmnxw3FLaDM0tkkKjoPCst+gAGAGSe8r7fhm07Bh5cfp2NSFN6o7EZfPvqOx0Pn9127t+VepGkRiE4HXetPcDAV9eGW0bzFfGRErYELb/LyB9xM+h4DBlwH+9vomEG2eqYR5i68EwSl/O6W5InxFhC/f+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH8PR12MB999203.namprd12.prod.outlook.com (2603:10b6:610:35a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Thu, 28 May 2026 13:23:22 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%4]) with mapi id 15.21.0071.010; Thu, 28 May 2026 13:23:22 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 28 May 2026 22:23:18 +0900 Message-Id: Cc: "Miguel Ojeda" , "Nicolas Schier" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , "David Airlie" , "Simona Vetter" , "John Hubbard" , "Alistair Popple" , "Timur Tabi" , "Zhi Wang" , "Eliot Courtney" , , , , , Subject: Re: [PATCH v2 1/7] scripts: modpost: detect and report truncated buf_printf() output From: "Alexandre Courbot" To: "Nathan Chancellor" References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> <20260527-nova-exports-v2-1-06de4c556d55@nvidia.com> <20260527171823.GA1893026@ax162> In-Reply-To: <20260527171823.GA1893026@ax162> X-ClientProxiedBy: TY4PR01CA0124.jpnprd01.prod.outlook.com (2603:1096:405:379::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH8PR12MB999203:EE_ X-MS-Office365-Filtering-Correlation-Id: 093f8d0c-e65b-4708-af4d-08debcbc4a14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|1800799024|376014|10070799003|3023799007|22082099003|18002099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: u1EY+NBDHOm/4tsNvDCP9e6ArrLQZrtXgGuC6+aba9xqa5Uz2iyAzcOIAFZ3LJWJSd2rTg4jOVX5o67oNGvdfXutWzTjkb6zUv/h/D2h6KyE7yONx1pqvXiPrwzjK6PswhCqMzCtboP18Ef2JrRFEBgnb1ODpFMNpWjAuuJsjZCM1f+fQrjKOnUNoEXCLxNYAbKvaIfeTDrbyqM7NdN7KJfhFEFrOpI/cU6uDP/ehvzcn/4Vwt0tAvv4IHJ+uMEQSQ8mUssAVrw2QKPf3jCO7lF8KSuh0JFhli6s2fxnt+vBzqLuBv7VmOEMUkCwpyNLv3OrP9XqjVBt/YWlgvNp0JCMvKUn3zBv7wn/HbzT1+mvOI/LSSD/g1FQm6tqUYKNs4SqY20Tw9xhITY1/dpZiN+hG22fbGz5kLisILyuhm+qJMEXwhNHQWVXt0wf+pSeOsP/Xth73mb/hRFxwpxUyhWjasX6VSv2aTM0o8bU/wdDxpTzwESvlMTGJQBb/oVd5gNVZT2+WwjMVNwMH7SH9ARCTYgVCMBNEqn5qXzgNmt2ysAjjo8sAMtO6g0Tu1vYdAVsxaAgx3Z3pA7UUT9zxp/6WDWlahvtOw8DUblpsRkiOjQxA3PIkbFspi8fLlV2dSp1l+KfkqpezMqezlqiH45SBohVrCtJWjFO1MYulQsMdRE75Ae+s/I6SVSzBe2b X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB3990.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(1800799024)(376014)(10070799003)(3023799007)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkJ3QUtreFlvdVliN3RWN2U3WEZUdVpRTVM2NkFLZ2ZIQUZQZitBN0IvTU5T?= =?utf-8?B?MkR4L3NpeEl3NE9jbmsvaHRuR0ZaQUp4eldWVXBiTDRxMUJpc0xpQ2o2MW1k?= =?utf-8?B?UmtvMVMxQWpGbldRcndqUTRWOXc3QnRyME1CMktvUUJpdnFlRzdvV0tJU0Ft?= =?utf-8?B?bUlSbC80bkVqMDV4V0ExZXdEYklVQzI3YXZ2ZUlrZjBia0cyc1lzek9QWSt1?= =?utf-8?B?UnplZit2MGxmV0hWejB5d0RzLzJwMXJ1SmtCdk81b1VrOXlYOEN5OUJydXBV?= =?utf-8?B?RVFmQzJScHpvUXFpb21KRXUwSklaeGxsUVNWbVV0YjFEZFl2RTN4WC9abkh3?= =?utf-8?B?Z3ZVbnBiRytoMTB6N0pXbTl2dVpsVkd2eW1XRUlieUNoL0RsUzJtMDVEdDNY?= =?utf-8?B?ODRscnRZdFBlWHdDdFAxOFpuVnJEVHhRZjJoRHRQRlUzdFArZ1RnUko5UTk5?= =?utf-8?B?NVRDeFYvV29HSVNYME9nVnBBcm9WQTFCY3pkVG1SeHhzMWF2ckJ5a2ovNzZY?= =?utf-8?B?eDRYNGlZN0RpQUZIVklGY0lGc3ltMEJXWG43cmFvRURnUU5EOWJ0aTVBYUdV?= =?utf-8?B?Z21vNi9BU2s4c0kvakd3c3gzRFR0eUp4LzRQS1Zxa3dLSmkyNWRVVWg1UnJm?= =?utf-8?B?Q0RUZmVrbzRQRDR1Z2VPU2dSSDg4NXZXWFU3Yy9aZHFoSk1uWE5lYldCTTBv?= =?utf-8?B?MkNrbW1LVzJjNzVhV1BqVDBlWit4VDdmOXZEdTdNSStMcW5NT1hPQXNGL3pL?= =?utf-8?B?cDlrME5TM0pLMWFGK1huNlVQT09QQy9kZG1wYjJJTVFNMThPcnN4WXQ5QWZT?= =?utf-8?B?OGRDd2gyQ3J0Wk8ydlRVVnEzMWR3K1kzZFN3RkVFMFFVZU9kYnh1QWR3WVNM?= =?utf-8?B?WDM1b2lJYmFldm1GTGw5cHBYRU83V2wyaWJ0TGllWjdCKzZDUHhRWUVrUU1T?= =?utf-8?B?S0FHV0FYVmpWZmxYRXY5c3dPU0lLdDhuZWY3dk1OVFA2cFpuZVFzZ0pDblpM?= =?utf-8?B?UHZJaU8vQnBKV2J6a1pDcW4vVUU3VU9IbXNKZHJTMWdrM1BsNStXSitONWhM?= =?utf-8?B?Slh4ZzdMeUFweEI2WnpOaTROU0I2RjJaQTVNTU5RWDdjTEJ4NEV3dVJ4dFZu?= =?utf-8?B?OVBJZGxuVEVETFZ5bTd2ZDdiME80NW5NOTFjb05NS084R3l4bEdJb2FNQ0RS?= =?utf-8?B?NmZETnBpaFlhWitwazZHKzRoWlJMeGlsdWJTSWM2b3c2dVhzaERBdTlJUmFN?= =?utf-8?B?ZUlRM1VwOGlYTkwyeTc3Q2ZMaFpUa25kMWdCYnl2WjVIY2tFc0g3cE5MSXcr?= =?utf-8?B?VDFab3c5bk9xUjF3QlJaNldJZHdjZjB2TkNyVUw4eWRYUU53WTAzb09ZVlp3?= =?utf-8?B?MjgxRjRHNnNJaG4xYTNqU0FPdHIxMDczSnAxOVRxckFST3RFR3hTYnE0Zjhr?= =?utf-8?B?Wm9aakNxb2RRZHpZemN4RWZ5Q1JpSnIwc1Q1WFZvdENkZXdMS2dTWmtxejFE?= =?utf-8?B?bWFwZE5GTVN2eHJ1QjdBbzdMZGlma0hmU0kxWVJIL2hRYXQ2NVJGaWROZlVj?= =?utf-8?B?SU5MK2FMa3lzMnY3WWVEaUlwWjJIV2plMEcvd29wdFlXYldIVVNHc0V4L0hO?= =?utf-8?B?WnZhcC9oMXFxMVZnQVdjdzl5Vm84YmpMekttZkJ6YjJnM1JwWjJ5a2hMcGx3?= =?utf-8?B?cWI2R2ZIMjV3ajQ3V2JmcTF0R3F2cS9EbUhYMlBNeUE5Q0F5T3RwaHMrR1dy?= =?utf-8?B?S0xrYm9qTkFUcWNrUmg4dnB5eXlTTm1heVUvUFBBV1dOeHRVcEdzWWE0T2R1?= =?utf-8?B?blRxejRNRUVyNFNOcWlVOUVyRGw1S0tEaXQ0bU1qRUhQWjRQWjNtQjNVdzZM?= =?utf-8?B?WmlSUW5JTHhsMHdnSW9vcm0yRTZJd2dHTUI4UXd2YWJCQW54S2JPbGlVM0tV?= =?utf-8?B?U2VNbThDdlVvejZzU1NZVU5UaEJnVDJTb2NKQmZ4TmdqczhtcUJYV1hwVjJ5?= =?utf-8?B?MnlBMTA1U251TTNoSlE2ek5qTHpKMW1hWktmK1I1TVA1Z2Zyc0doZ3BTdFFW?= =?utf-8?B?d1N1NlE5ZEVMOFBEcnhBTU5XanlMd1lXYXVsSkRZVHc0TXNHdnVmQzZ1UC9V?= =?utf-8?B?cFpLbHRvUGxsQ3ZYVWxHTWpBd0Z0RUJFZGZzQmg4MWU2SGIyd0ZlVzQ1VE9m?= =?utf-8?B?MFlMMGlDakV3U21id2RzWEV0cDlyYkZ2OXRicjBvOVI5MEdCdjF2MjU1TkJJ?= =?utf-8?B?ZC9qRGREZHQ2cU54TWVTVjBFZGU3QVpIYWNnMkp2eG1FVVcyTy80RWRxaWpp?= =?utf-8?B?MDhoSlRSOWhiSTVMR3pRaFpCOHBYSFoxUXYzOVBxK2x6NWFBWmJXTzEzazZE?= =?utf-8?Q?SRkcIifMtbE7XkUHq9KIvT3D/+TGVWK4WE9w26xEqH6Re?= X-MS-Exchange-AntiSpam-MessageData-1: YJMx+nDZpDki6A== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 093f8d0c-e65b-4708-af4d-08debcbc4a14 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2026 13:23:21.8112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TeZLwdAYcBnEk87ra7L3omL/4nrxtBAv1uBSleWwVLVEEoLVicHKY5gsda4IvE5jIkV3SzTXC+6dlvDVzH1hnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR12MB999203 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nathan, On Thu May 28, 2026 at 2:18 AM JST, Nathan Chancellor wrote: > On Wed, May 27, 2026 at 08:52:17PM +0900, Alexandre Courbot wrote: >> buf_printf() uses a fixed-size stack buffer. vsnprintf() returns the >> number of bytes that *would* have been written to that buffer, which can >> be larger than the size of said buffer if the formatted string is too >> long. >>=20 >> The problem is that whenever this happens buf_printf() currently passes >> this length, unchecked, to buf_write(), which silently reads past the >> stack buffer and copies invalid data into the output buffer. >>=20 >> Fix this by detecting vsnprintf() failures and truncations before >> appending to the output buffer, and report a fatal error instead of >> producing corrupt symbol names. >>=20 >> Signed-off-by: Alexandre Courbot > > Acked-by: Nathan Chancellor If that works for you, can you take this patch through the build tree? I've included it in this series because it detects the issue that the series fixes, but it is not a dependency for the next patches. I just wanted to include it for context.